Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: comment mount-options in example #276

Merged

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind documentation

What this PR does / why we need it:
doc: remove mount-options in example

Which issue(s) this PR fixes:

Fixes #274

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2022
@k8s-ci-robot k8s-ci-robot requested review from humblec and pohly January 26, 2022 06:55
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 26, 2022
@andyzhangx andyzhangx force-pushed the remove-mount-options-in-example branch from ee6a07c to a8d7899 Compare January 26, 2022 08:33
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1749812265

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.716%

Totals Coverage Status
Change from base Build 1749473497: 0.0%
Covered Lines: 558
Relevant Lines: 718

💛 - Coveralls

@pohly
Copy link
Contributor

pohly commented Jan 26, 2022

Why this change?

I have no opinion about it. But as I don't see a reason in the commit message or the PR description, I can't review this.

@andyzhangx
Copy link
Member Author

andyzhangx commented Jan 26, 2022

Why this change?

I have no opinion about it. But as I don't see a reason in the commit message or the PR description, I can't review this.

this PR fixed #274, we only want to make this secret optional in storage class example, otherwise user would hit error when applying this example. I renamed this PR title to comment mount-options in example

@andyzhangx andyzhangx changed the title doc: remove mount-options in example doc: comment mount-options in example Jan 26, 2022
@YuikoTakada
Copy link
Contributor

Thank you for your PR.
Is this /kind documentation ? not /kind bug ?

@andyzhangx
Copy link
Member Author

Thank you for your PR. Is this /kind documentation ? not /kind bug ?

@YuikoTakada aha, it's doc bug

@andyzhangx andyzhangx merged commit 56f1dfc into kubernetes-csi:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hack/verify-examples.sh fails with 'secrets "mount-options" not found' error
5 participants