-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: comment mount-options in example #276
doc: comment mount-options in example #276
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ee6a07c
to
a8d7899
Compare
Pull Request Test Coverage Report for Build 1749812265
💛 - Coveralls |
Why this change? I have no opinion about it. But as I don't see a reason in the commit message or the PR description, I can't review this. |
this PR fixed #274, we only want to make this secret optional in storage class example, otherwise user would hit error when applying this example. I renamed this PR title to |
Thank you for your PR. |
@YuikoTakada aha, it's doc bug |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
doc: remove mount-options in example
Which issue(s) this PR fixes:
Fixes #274
Special notes for your reviewer:
Does this PR introduce a user-facing change?: