Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade to k8s v1.23.3 lib #282

Merged
merged 2 commits into from
Feb 8, 2022
Merged

chore: upgrade to k8s v1.23.3 lib #282

merged 2 commits into from
Feb 8, 2022

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
chore: upgrade to k8s v1.23.3 lib

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

chore: upgrade to k8s v1.23.3 lib

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 6, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 6, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1802480423

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.716%
Totals Coverage Status
Change from base Build 1765252627: 0.0%
Covered Lines: 558
Relevant Lines: 718
💛 - Coveralls

xing-yang
xing-yang reviewed Feb 6, 2022
View reviewed changes
go.mod
k8s.io/api v0.23.0
k8s.io/apimachinery v0.23.0
k8s.io/client-go v0.23.0
k8s.io/api v0.23.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We normally update the dependencies with every K8s release. This was updated to 0.23.0 already. Is there anything specific in 0.23.3 that we need right now or can we wait until 1.24 release to update?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I see, let me only update mount-utils package change(with cherry-pick fix) in v1.23.3

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I only upgrade mount-utils to v0.23.3, then there is go mod error, so let's upgrade to v1.23.3 for all related modules since there is no harm, agree? @xing-yang

# go mod tidy
go: k8s.io/kubernetes@v1.23.3 requires
        k8s.io/mount-utils@v0.0.0: reading k8s.io/mount-utils/go.mod at revision v0.0.0: unknown revision v0.0.0
go: k8s.io/kubernetes@v1.23.3 requires
        k8s.io/mount-utils@v0.0.0: reading k8s.io/mount-utils/go.mod at revision v0.0.0: unknown revision v0.0.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [andyzhangx,xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 209c441 into kubernetes-csi:master Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@humblec humblec Awaiting requested review from humblec

@j-griffith j-griffith Awaiting requested review from j-griffith

Assignees

@xing-yang xing-yang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andyzhangx @coveralls @xing-yang @k8s-ci-robot