Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add subDir in storage class parameters #349

Merged
merged 2 commits into from
Jun 13, 2022
Merged

feat: add subDir in storage class parameters #349

merged 2 commits into from
Jun 13, 2022

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: add subDir in storage class parameters

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

feat: add subDir in storage class parameters

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 11, 2022
@coveralls
Copy link

coveralls commented Jun 11, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2483467578

  • 62 of 67 (92.54%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 76.933%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/nfs/nodeserver.go 2 7 28.57%
Totals Coverage Status
Change from base Build 2462377990: 0.4%
Covered Lines: 587
Relevant Lines: 763
💛 - Coveralls

@andyzhangx andyzhangx force-pushed the subDir branch 2 times, most recently from fa8dc26 to 8b0485c Compare June 12, 2022 02:32
@andyzhangx andyzhangx changed the title [WIP]feat: add subDir in storage class parameters feat: add subDir in storage class parameters Jun 12, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2022
@andyzhangx andyzhangx changed the title feat: add subDir in storage class parameters [WIP]feat: add subDir in storage class parameters Jun 12, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2022
@andyzhangx andyzhangx force-pushed the subDir branch 4 times, most recently from a08845f to cfd8d86 Compare June 12, 2022 08:26
@andyzhangx
feat: add subDir in storage class parameters
16c442a 
fix subdir

internal mount fix

mount subdir in NodePublishVolume

fix golint

fix

fix

setKeyValueInMap
@andyzhangx andyzhangx changed the title [WIP]feat: add subDir in storage class parameters feat: add subDir in storage class parameters Jun 12, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2022
@andyzhangx andyzhangx merged commit bd1d58e into kubernetes-csi:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyzhangx @k8s-ci-robot @coveralls