Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: chart lint errors in v4.0.0 and v4.1.0 #405

Merged
merged 1 commit into from
Jan 28, 2023
Merged

fix: chart lint errors in v4.0.0 and v4.1.0 #405

merged 1 commit into from
Jan 28, 2023

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Jan 28, 2023 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: chart lint errors in v4.0.0 and v4.1.0

Which issue(s) this PR fixes:

Fixes #404

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: chart lint errors in v4.0.0 and v4.1.0

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2023
@andyzhangx andyzhangx changed the title fix: fix chart lint errors in v4.0.0 and v4.1.0 fix: chart lint errors in v4.0.0 and v4.1.0 Jan 28, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 28, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4031003054

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.33%
Totals Coverage Status
Change from base Build 4006354950: 0.0%
Covered Lines: 614
Relevant Lines: 794
💛 - Coveralls

@andyzhangx
Copy link
Member Author

/test pull-csi-driver-nfs-e2e

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx merged commit 3a51fd3 into kubernetes-csi:master Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaunakShah RaunakShah Awaiting requested review from RaunakShah

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

helm lint fails
3 participants
@andyzhangx @k8s-ci-robot @coveralls