Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E test cases for dynamic provisioning #79

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

mayankshah1607
Copy link
Contributor

@mayankshah1607 mayankshah1607 commented Nov 12, 2020

Signed-off-by: Mayank Shah mayankshah1614@gmail.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Add the following E2E tests for dynamic provisioning

  • DynamicallyProvisionedCollocatedPodTest
  • DynamicallyProvisionedReadOnlyVolumeTest
  • DynamicallyProvisionedDeletePodTest
  • DynamicallyProvisionedReclaimPolicyTest
  • DynamicallyProvisionedPodWithMultiplePVTest

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 12, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 12, 2020
@mayankshah1607 mayankshah1607 force-pushed the e2e branch 3 times, most recently from fcb831e to 50b0a77 Compare November 12, 2020 08:19
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 12, 2020
- DynamicallyProvisionedCollocatedPodTest
- DynamicallyProvisionedReadOnlyVolumeTest
- DynamicallyProvisionedDeletePodTest
- DynamicallyProvisionedReclaimPolicyTest
- DynamicallyProvisionedPodWithMultiplePVTest

Signed-off-by: Mayank Shah <mayankshah1614@gmail.com>
@mayankshah1607 mayankshah1607 changed the title [WIP] Add E2E test cases for dynamic provisioning Add E2E test cases for dynamic provisioning Nov 12, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 12, 2020
@andyzhangx
Copy link
Member

andyzhangx commented Nov 12, 2020

in the e2e test logs, it said:

ERROR: logging before flag.Parse: I1112 10:03:22.651303   12142 nfs.go:56] Driver: nfs.csi.k8s.io version: 2.0.0

I think we need to change the version name on master branch, it should be 3.0.0

Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, mayankshah1607

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit cf5280d into kubernetes-csi:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants