-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kubernetes to 1.32 #185
Conversation
Hi @dfajmon. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dfajmon, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Do we really need to update the deps so often? This is a lib, and does not produce executable itself. Bumping dep version forces every consumer to update transitive deps when updating this module, which is unnecessary. I think we should only update the deps when we really depend on the new feature. Consumers can still use newer version than declared in this repo. |
@huww98 We update libraries once for release unless there are bug fixes that might need more bumps. It's also better to have a unified Kubernetes version across all projects in one release. |
I agree with this for modules that produce executable, and rarely imported by other projects. But for module like this repo, updating has no benefits, I think. Golang will pick the updated version specified in the main module anyway. Our project is currently using client-go 1.30.0, and I just want to use the new protosanitizer ( |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Bump Kubernetes to v1.32.0
Does this PR introduce a user-facing change?: