Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubernetes to 1.32 #185

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

dfajmon
Copy link
Contributor

@dfajmon dfajmon commented Dec 17, 2024

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Bump Kubernetes to v1.32.0

Does this PR introduce a user-facing change?:

Update Kubernetes dependencies to 1.32.0

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 17, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @dfajmon. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 17, 2024
@jsafrane
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 17, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 17, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 17, 2024
@jsafrane
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfajmon, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0b6c8eb into kubernetes-csi:master Dec 17, 2024
3 checks passed
@dfajmon dfajmon deleted the bump branch December 17, 2024 15:06
@huww98
Copy link
Contributor

huww98 commented Dec 19, 2024

Do we really need to update the deps so often? This is a lib, and does not produce executable itself. Bumping dep version forces every consumer to update transitive deps when updating this module, which is unnecessary. I think we should only update the deps when we really depend on the new feature. Consumers can still use newer version than declared in this repo.

@dfajmon
Copy link
Contributor Author

dfajmon commented Dec 19, 2024

@huww98 We update libraries once for release unless there are bug fixes that might need more bumps. It's also better to have a unified Kubernetes version across all projects in one release.

@huww98
Copy link
Contributor

huww98 commented Dec 19, 2024

It's also better to have a unified Kubernetes version across all projects in one release.

I agree with this for modules that produce executable, and rarely imported by other projects. But for module like this repo, updating has no benefits, I think. Golang will pick the updated version specified in the main module anyway.

Our project is currently using client-go 1.30.0, and I just want to use the new protosanitizer (1 file changed, 56 insertions(+), 113 deletions(-)). And that go mod vendor brings me 1981 files changed, 60843 insertions(+), 117187 deletions(-) to my vendor dir, which is far more than necessary. Yes, we will upgrade eventually. But I think it is not necessary to force every project in the community to follow tightly. At least allow us to use the still maintained backport version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants