Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct markdown formatting. #9

Closed
wants to merge 1 commit into from
Closed

Correct markdown formatting. #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ Learn how to engage with the Kubernetes community on the [community page](http:/

You can reach the maintainers of this project at:

- [Slack](http://slack.k8s.io/)
- [Mailing List](https://groups.google.com/forum/#!forum/kubernetes-dev)
* [Slack](http://slack.k8s.io/)
* [Mailing List](https://groups.google.com/forum/#!forum/kubernetes-dev)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are bullets better than hyphens? Both are listed as valid markup for lists in multiple places:
https://en.support.wordpress.com/markdown-quick-reference/
https://guides.github.com/features/mastering-markdown/

This particular text fragment comes from the Kubernetes template for new repos: https://github.com/kubernetes/kubernetes-template-project

I don't think we should deviate from that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@humblec did you use some linter tool to find these changes? Can we work on adding common fmt/linting tools to the csi-lib-utils repo so the rules are consistent across all repos?


### Code of conduct

Expand Down