test: migrate tests to HostProcess pods #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
alexander-ding
force-pushed
the
enh/migrate-v2
branch
3 times, most recently
from
292024d
to
67e7a12
Compare
alexander-ding
force-pushed
the
enh/migrate-v2
branch
from
67e7a12
to
c112ff0
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-ding, mauriciopoppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
As we migrate to a library model, the tests need to more closely mimic the runtime environment of the code, which is in HostProcess containers. Thus, this PR updates the tests to spin up a pod running HostProcess containers to execute the tests, instead of directly running the test binary on the Windows node.
Which issue(s) this PR fixes:
Fixes #227
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/cc @mauriciopoppe