-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set GOMODCACHE to avoid re-download toolchain #267
Conversation
If we don't set this, k/k build script will set GOMODCACHE different from default, and re-download the toolchain (or fail to build for Kubernetes <= 1.29).
Hi @huww98. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/release-note-none |
@huww98 i see GOCACHE is also being set in the k/k scripts. should that also be overwritten here? |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huww98, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
If we don't set this, k/k build script will set GOMODCACHE different from default, and re-download the toolchain (or fail to build for Kubernetes <= 1.29).
/release-note-none