-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cloudbuild image with go 1.21+ #268
Conversation
This is required for the GOTOOLCHAIN env to be effective. Fixes: 6b05f0f
Hi @huww98. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Thanks, Adding the following info to help reviewers. https://prow.k8s.io/?type=postsubmit&job=*external*-push-images&state=failure This fix is related to recent image push failures
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test pull-kubernetes-csi-release-tools-external-provisioner |
/ok-to-test |
/ok-to-test |
FYI External-snapshotter Data Race was fixed in v8.2.0 by bumping prometheus/client_golang, which should fix the |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huww98, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merge pull request [pull request kubernetes-csi#268](kubernetes-csi/csi-release-tools#268) from huww98/cloudbuild Merge pull request [pull request kubernetes-csi#266](kubernetes-csi/csi-release-tools#266) from jsafrane/bump-sanity-5.3.1 Signed-off-by: Rakshith R <rar@redhat.com>
This is required for the GOTOOLCHAIN env to be effective.
It contains go1.22.5
Fixes: 6b05f0f
Fixes: #262