Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cloudbuild image with go 1.21+ #268

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

huww98
Copy link
Contributor

@huww98 huww98 commented Dec 12, 2024

This is required for the GOTOOLCHAIN env to be effective.

It contains go1.22.5

Fixes: 6b05f0f
Fixes: #262

NONE

This is required for the GOTOOLCHAIN env to be effective.

Fixes: 6b05f0f
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 12, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 12, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @huww98. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 12, 2024
@Rakshith-R
Copy link
Contributor

Thanks,

Adding the following info to help reviewers.

https://prow.k8s.io/?type=postsubmit&job=*external*-push-images&state=failure

This fix is related to recent image push failures

ERROR: Please install Go 1.21+
ERROR
ERROR: build step 0 "gcr.io/k8s-testimages/gcb-docker-gcloud:v20230623-56e06d7c18" failed: step exited with non-zero status: 1
--------------------------------------------------------------------------------
2024/12/11 13:15:24 Failed to run some build jobs: [error running [gcloud builds submit --verbosity info --config /home/prow/go/src/github.com/kubernetes-csi/external-provisioner/cloudbuild.yaml --substitutions _PULL_BASE_REF=master,_GIT_TAG=v20241211-v5.1.0-28-g7463124e --project k8s-staging-sig-storage --gcs-log-dir gs://k8s-staging-sig-storage-gcb/logs --gcs-source-staging-dir gs://k8s-staging-sig-storage-gcb/source gs://k8s-staging-sig-storage-gcb/source/04e41d36-f2f0-45f0-a6eb-6385641058eb.tgz]: exit status 1]

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2024
Copy link

@AndrewSirenko AndrewSirenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@AndrewSirenko
Copy link

/test pull-kubernetes-csi-release-tools-external-provisioner

@xing-yang
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 16, 2024
@jsafrane
Copy link
Contributor

/ok-to-test

@AndrewSirenko
Copy link

FYI External-snapshotter Data Race was fixed in v8.2.0 by bumping prometheus/client_golang, which should fix the pull-kubernetes-csi-release-tools-external-snapshotter failure.

@jsafrane
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huww98, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0496593 into kubernetes-csi:master Dec 17, 2024
9 checks passed
Rakshith-R added a commit to Rakshith-R/external-snapshot-metadata that referenced this pull request Dec 17, 2024
Merge pull request [pull request kubernetes-csi#268](kubernetes-csi/csi-release-tools#268) from huww98/cloudbuild
Merge pull request [pull request kubernetes-csi#266](kubernetes-csi/csi-release-tools#266) from jsafrane/bump-sanity-5.3.1

Signed-off-by: Rakshith R <rar@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants