Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to Go 1.12.4 #191

Merged
merged 3 commits into from
Apr 15, 2019
Merged

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Apr 15, 2019

Imports the latest csi-release-tools and fixes a compatibility problem in e8500f2.

pohly added 2 commits April 15, 2019 09:45
Kubernetes also requires 1.12. We pick the latest stable release
for CI builds.
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 15, 2019
@k8s-ci-robot k8s-ci-robot requested review from msau42 and saad-ali April 15, 2019 08:47
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 15, 2019
@pohly pohly changed the title update to Go 1.12.4 WIP: update to Go 1.12.4 Apr 15, 2019
@pohly pohly changed the title WIP: update to Go 1.12.4 update to Go 1.12.4 Apr 15, 2019
@pohly pohly changed the title update to Go 1.12.4 WIP: update to Go 1.12.4 Apr 15, 2019
@pohly pohly marked this pull request as ready for review April 15, 2019 08:48
GOCACHE=off is too strong (prevents reusing binaries) and is going to
break when updating to Go 1.12.x. Better use the `-count=1` trick to
force a re-run of the
tests (golang/go#24573 (comment)).
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pohly pohly changed the title WIP: update to Go 1.12.4 update to Go 1.12.4 Apr 15, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2019
@msau42
Copy link
Collaborator

msau42 commented Apr 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 13e6b8a into kubernetes-csi:master Apr 15, 2019
suneeth51 pushed a commit to suneeth51/csi-test that referenced this pull request Sep 11, 2019
stmcginnis pushed a commit to stmcginnis/csi-test that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants