-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ID Generator interface for generating valid IDs for Volume and Node #212
Add ID Generator interface for generating valid IDs for Volume and Node #212
Conversation
/cc @displague @tamalsaha @sanjid133 |
@davidz627: GitHub didn't allow me to request PR reviews from the following users: displague, tamalsaha, sanjid133. Note that only kubernetes-csi members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
880b0b8
to
2932c8a
Compare
Tested and working with PD driver |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Why is that? If this config isn't set it will default to doing the same thing as before (except with UUID's instead of just using |
Oh I see, this is a new optional config argument. I think that's fine then. |
2932c8a
to
43c8a31
Compare
/lgtm |
…erator Add ID Generator interface for generating valid IDs for Volume and Node
/kind api-change
/kind feature
Fixes #103