Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ID Generator interface for generating valid IDs for Volume and Node #212

Merged

Conversation

davidz627
Copy link
Contributor

/kind api-change
/kind feature

Fixes #103

Adds an interface for generating Volume/Node IDs that users can plug in for ID's that must conform to valid format

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 6, 2019
@k8s-ci-robot k8s-ci-robot requested review from jsafrane and pohly August 6, 2019 21:01
@davidz627
Copy link
Contributor Author

/assign @msau42 @lpabon

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 6, 2019
@davidz627
Copy link
Contributor Author

/cc @displague @tamalsaha @sanjid133
does this work for your issues

@k8s-ci-robot
Copy link
Contributor

@davidz627: GitHub didn't allow me to request PR reviews from the following users: displague, tamalsaha, sanjid133.

Note that only kubernetes-csi members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @displague @tamalsaha @sanjid133
does this work for your issues

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 6, 2019
@davidz627 davidz627 force-pushed the feature/volIDGenerator branch 2 times, most recently from 880b0b8 to 2932c8a Compare August 6, 2019 23:08
@davidz627
Copy link
Contributor Author

Tested and working with PD driver

@davidz627 davidz627 changed the title Add Volume ID Generator interface for generating valid ID's Add ID Generator interface for generating valid ID's Aug 6, 2019
@davidz627 davidz627 changed the title Add ID Generator interface for generating valid ID's Add ID Generator interface for generating valid IDs for Volume and Node Aug 6, 2019
@msau42
Copy link
Collaborator

msau42 commented Aug 6, 2019

We'll need to cut a new major for this, which I think is fine. Would like one more reviewer on this.

/assign @jsafrane @lpabon
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2019
@davidz627
Copy link
Contributor Author

We'll need to cut a new major for this, which I think is fine. Would like one more reviewer on this.

Why is that? If this config isn't set it will default to doing the same thing as before (except with UUID's instead of just using fakevol/testvol/id etc.)

@msau42
Copy link
Collaborator

msau42 commented Aug 7, 2019

Oh I see, this is a new optional config argument. I think that's fine then.

pkg/sanity/util.go Outdated Show resolved Hide resolved
@davidz627 davidz627 force-pushed the feature/volIDGenerator branch from 2932c8a to 43c8a31 Compare August 7, 2019 20:25
@msau42
Copy link
Collaborator

msau42 commented Aug 7, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit fda8ad3 into kubernetes-csi:master Aug 7, 2019
@davidz627 davidz627 deleted the feature/volIDGenerator branch August 7, 2019 21:45
@davidz627
Copy link
Contributor Author

sweet! @msau42 @lpabon have time to cut a new release?

suneeth51 pushed a commit to suneeth51/csi-test that referenced this pull request Sep 11, 2019
…erator

Add ID Generator interface for generating valid IDs for Volume and Node
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support volume name generate interface
5 participants