Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Portworx driver version and name #167

Merged
merged 1 commit into from
Jun 2, 2019
Merged

Update Portworx driver version and name #167

merged 1 commit into from
Jun 2, 2019

Conversation

ggriffiths
Copy link
Member

@ggriffiths ggriffiths commented May 31, 2019 •
edited
Loading

A few quick updates to our driver documentation.

NONE

@k8s-ci-robot
Copy link
Contributor

Welcome @ggriffiths!

It looks like this is your first PR to kubernetes-csi/docs 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/docs has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 31, 2019
@k8s-ci-robot k8s-ci-robot requested review from msau42 and saad-ali May 31, 2019 21:11
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 31, 2019
@ggriffiths ggriffiths force-pushed the ggriffiths-patch-1 branch from 1591ea1 to 91b3a9c Compare May 31, 2019 22:00
@ggriffiths ggriffiths force-pushed the ggriffiths-patch-1 branch from 91b3a9c to 3cba8eb Compare May 31, 2019 22:50
@saad-ali
Copy link
Member

saad-ali commented Jun 2, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggriffiths, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3f66240 into kubernetes-csi:master Jun 2, 2019
@ggriffiths ggriffiths mentioned this pull request Oct 18, 2019
Closed
6 tasks
@ggriffiths ggriffiths mentioned this pull request Dec 11, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saad-ali saad-ali saad-ali approved these changes

@msau42 msau42 Awaiting requested review from msau42

Assignees

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggriffiths @k8s-ci-robot @saad-ali