Add CSI secret templates as annotation in Provisioned PV

[mkimuram]

There was a discussion in the meeting on PVC/Snapshot transfer about the model that operation on PV should not rely on information in StorageClass after PV is provisioned. The reason for it is that StorageClass can be changed after the PV is provisioned, as a result, the controllers might not rely on the current information in StorageClass.

In the case of PVC transfer, SecretRef in PV may be modified based on the templates after transferred. Therefore, these templates should be kept in PV as annotations.

[humblec]

@mkimuram sure, indeed as the discussion went yesterday, its good to take out the storage class dependency once the pv is provisioned. however I am not sure we were in complete agreement though, especially when the discussion is moving towards transfer of snap vs transfer of pv.

[xing-yang]

I thought this is already done and documented here: https://kubernetes-csi.github.io/docs/secrets-and-credentials-storage-class.html

Is there anything missing?

CC @msau42

[mkimuram]

Please see related discussion kubernetes-csi/external-snapshotter#578 (comment) .

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[mowangdk]

I have further questions related with this issue.

We can upgrade the disk type after provisioned on the fly. but spec.csi.volumeAttributes in PersistentVolume is immutable。 How can i fix PersistentVolume type right in this scenario?

@xing-yang @msau42 Any suggestions would really appreciated 🙇

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.