-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: introduce /v5 module suffix for go.mod #1236
Conversation
Hi @jakobmoellerdev. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
f67a9ac
to
61c5174
Compare
changes the go.mod path to add /v5 so that go module is resolved properly
@msau42 I think Line 3 in c66e140
external-provisioner/release-tools/prow.sh Line 1038 in e96448a
external-provisioner/release-tools/prow.sh Line 977 in e96448a
Any preference on how to fix that? |
@jakobmoellerdev What do you think of creating a new variable? Edits to release-tools need to be done in https://github.com/kubernetes-csi/csi-release-tools/blob/master/prow.sh? first and than imported here as a git submodule (instructions are in the repo) |
@msau42 I would need a checkup on the tools PR so that we can unblock that. |
/retest |
988496a1f Merge pull request kubernetes-csi#257 from jakobmoellerdev/csi-prow-sidecar-e2e-path 028f8c698 chore: bump to Go 1.22.5 69bd71e8a chore: add CSI_PROW_SIDECAR_E2E_PATH f40f0ccd4 Merge pull request kubernetes-csi#256 from solumath/master cfa92106c Instruction update git-subtree-dir: release-tools git-subtree-split: 988496a1fc3849ed793e03012fdd56813d13d46c
@msau42 thanks to the adjustment in the release tooling this one is now good to go 👍 |
/lgtm Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakobmoellerdev, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
changes the go.mod path to add /v5 so that go module is resolved properly
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Adds the /v5 suffix that was missed on previous releases so that the go.mod resolves properly
Special notes for your reviewer:
Opened as per request on https://kubernetes.slack.com/archives/C09QZFCE5/p1718782253879689
Does this PR introduce a user-facing change?: