-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change annotation name to allow volume mode change #791
Change annotation name to allow volume mode change #791
Conversation
In the release node, please clarify the old annotation and the new one. |
Please also submit a PR to kubernetes-csi/docs to describe this feature. |
I see that you've submitted a doc and it is also merged, but it is not shown up in here: https://kubernetes-csi.github.io/docs/features.html Please also update this file to add an entry: https://raw.githubusercontent.com/kubernetes-csi/docs/master/book/src/SUMMARY.md |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RaunakShah, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR updates the annotation that needs to be applies to
VolumeSnapshotContents
fromsnapshot.storage.kubernetes.io/allowVolumeModeChange
tosnapshot.storage.kubernetes.io/allow-volume-mode-change
.The feature is still in the Alpha stage.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: