Alpha support for provision volumes from cross-namespace data sources #805

ttakahashi21 · 2022-11-03T15:19:16Z

What type of PR is this?
/kind feature

What this PR does / why we need it:
Please see CrossNamespaceVolumeDataSource

Which issue(s) this PR fixes:

Part of ##804

Special notes for your reviewer:
Discuss the API definition kubernetes/kubernetes#113186.
The code may change due to API specification changes.

Does this PR introduce a user-facing change?:

Add support for cross-namespace data sources alpha feature

k8s-ci-robot · 2022-11-03T15:19:24Z

Welcome @ttakahashi21!

It looks like this is your first PR to kubernetes-csi/external-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-provisioner has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-11-03T15:19:25Z

Hi @ttakahashi21. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

humblec · 2022-11-04T08:21:17Z

pkg/controller/controller.go

@@ -57,6 +59,7 @@ import (
 	"github.com/kubernetes-csi/csi-lib-utils/rpc"
 	snapapi "github.com/kubernetes-csi/external-snapshotter/client/v6/apis/volumesnapshot/v1"
 	snapclientset "github.com/kubernetes-csi/external-snapshotter/client/v6/clientset/versioned"
+	referenceGrantv1alpha2 "sigs.k8s.io/gateway-api/pkg/client/listers/apis/v1alpha2"


just wondering , considering we have v1beta1 available cant we use v1beta1 of RefGrants insted of alphav2? Isnt it better to use it ? @ttakahashi21

The ReferenceGrant is not yet in beta. Therefore, I'm using Alpha2.
See the URL below.
https://github.com/kubernetes-sigs/gateway-api

@ttakahashi21 isnt this https://github.com/kubernetes-sigs/gateway-api/tree/main/pkg/client/listers/apis/v1beta1 available ?

I was able to use it by adding the following to my go.mod file:

require sigs.k8s.io/gateway-api v0.5.1-0.20221110191515-2d586cc49ab4

humblec · 2022-11-04T08:26:04Z

pkg/features/features.go

-	HonorPVReclaimPolicy: {Default: false, PreRelease: featuregate.Alpha},
+	Topology:                         {Default: false, PreRelease: featuregate.GA},
+	HonorPVReclaimPolicy:             {Default: false, PreRelease: featuregate.Alpha},
+	CrossNamespaceSourceProvisioning: {Default: false, PreRelease: featuregate.Alpha},


we also need to add this feature gate to the readme doc

Could you tell me where should i write it?

Added CrossNamespaceVolumeDataSource in README.md.

humblec · 2022-11-04T08:27:03Z

@ttakahashi21 thanks. I have few review comments . Apart from that, can we add some tests to this PR ?

humblec · 2022-11-04T08:28:14Z

/ok-to-test

xing-yang · 2022-11-04T21:15:06Z

pkg/controller/controller.go

@@ -57,6 +59,7 @@ import (
 	"github.com/kubernetes-csi/csi-lib-utils/rpc"
 	snapapi "github.com/kubernetes-csi/external-snapshotter/client/v6/apis/volumesnapshot/v1"
 	snapclientset "github.com/kubernetes-csi/external-snapshotter/client/v6/clientset/versioned"
+	referenceGrantv1alpha2 "sigs.k8s.io/gateway-api/pkg/client/listers/apis/v1alpha2"


xing-yang · 2022-11-04T21:29:15Z

pkg/controller/controller.go

+		return p.getSnapshotSourceInternal(ctx, claim, sc, claim.Namespace, claim.Spec.DataSourceRef2.Name)
+	}
+
+	if ok, err := p.IsGranted(ctx, claim.Spec.DataSourceRef2.Namespace, claim.Spec.DataSourceRef2.Name, claim); err != nil || !ok {


Do we check somewhere if the PVC namespace is the same as the VolumeSnapshot namespace? If they are the same, then referenceGrant is not needed.

Do we check somewhere if the PVC namespace is the same as the VolumeSnapshot namespace?

Changed to check.

@robscott
Do you have any comments from the gateway api point of view?

I'm not sure I get the context here. Agree that ReferenceGrant is only useful/necessary to enable cross-namespace references. Same namespace references should not require a ReferenceGrant.

ttakahashi21 · 2022-11-14T20:10:39Z

/assign msau42

msau42 · 2022-11-15T00:55:29Z

deploy/kubernetes/rbac.yaml

@@ -57,6 +57,9 @@ rules:
  - apiGroups: ["storage.k8s.io"]
    resources: ["volumeattachments"]
    verbs: ["get", "list", "watch"]
+  - apiGroups: ["gateway.networking.k8s.io"]


Can you comment these out for now with a note that it's alpha?

I see. But if I comment it out, CI fails. Is it possible to test without commenting out in the CI side test?

what is the test failure you see?

msau42 · 2022-11-15T00:57:11Z

go.mod

 	sigs.k8s.io/json v0.0.0-20220713155537-f223a00ba0e2 // indirect
 	sigs.k8s.io/structured-merge-diff/v4 v4.2.3 // indirect
 	sigs.k8s.io/yaml v1.3.0 // indirect
 )

-replace k8s.io/api => k8s.io/api v0.25.2
+replace k8s.io/api => k8s.io/api v0.0.0-20221110160654-5cb32024090c


does this support human-friendly tags like v1.26.0-beta.0?

I set it temporarily because I need to use the API added for k8s 1.26 for successful CI testing. Therefore, I will change it when the release tag is attached.

msau42 · 2022-11-15T01:18:56Z

pkg/controller/controller.go

+				}
+				rc.snapshot = true
+			default:
+				return nil, controller.ProvisioningFinished, fmt.Errorf("the PVC source specified via DataSourceRef with non-empty namespace does not belong to the right Kind.  Expected %s, Got %s", snapshotKind, claim.Spec.DataSourceRef.Kind)


Are we allowing pvc source and data populators too?

Yes. Added. 1f9df93

msau42 · 2022-11-15T01:25:34Z

pkg/controller/controller.go

+		}
+
+		for _, to := range grant.Spec.To {
+			if to.Group != snapshotAPIGroup || to.Kind != snapshotKind {


Can we make the function more generic to handle non-snapshot data sources?

Yes. Is possible. Fixed code 1f9df93

msau42 · 2022-11-15T01:30:38Z

pkg/controller/controller.go

@@ -582,6 +589,21 @@ func (p *csiProvisioner) prepareProvision(ctx context.Context, claim *v1.Persist
 			}
 		}
 	}
+
+	if utilfeature.DefaultFeatureGate.Enabled(features.CrossNamespaceVolumeDataSource) {
+		if claim.Spec.DataSourceRef != nil && claim.Spec.DataSourceRef.Namespace != nil && len(*claim.Spec.DataSourceRef.Namespace) > 0 {


I think we should move the check for feature gate and return error earlier at this place. There's a number of csi calls we make after this that may be nice to avoid.

I added feature gate check code early in the prepare Provision function.

msau42 · 2022-11-15T01:38:09Z

pkg/controller/controller.go

-	if claim.Spec.DataSource != nil && (rc.clone || rc.snapshot) {
+	if claim.Spec.DataSourceRef != nil && claim.Spec.DataSourceRef.Namespace != nil && len(*claim.Spec.DataSourceRef.Namespace) > 0 {
+		if utilfeature.DefaultFeatureGate.Enabled(features.CrossNamespaceVolumeDataSource) && rc.snapshot {
+			volumeContentSource, err := p.getVolumeContentSourceFromXnsDataSource(ctx, claim, sc)


Do we need a new function, or can we modify getVolumeContentSource?

Yes. Is possible. Fixed code 1f9df93
Could you check code?

msau42 · 2022-11-22T01:55:42Z

deploy/kubernetes/rbac.yaml

@@ -57,6 +57,9 @@ rules:
  - apiGroups: ["storage.k8s.io"]
    resources: ["volumeattachments"]
    verbs: ["get", "list", "watch"]
+  - apiGroups: ["gateway.networking.k8s.io"]


what is the test failure you see?

msau42 · 2022-11-22T01:56:37Z

go.mod

@@ -29,6 +29,8 @@ require (
 	sigs.k8s.io/sig-storage-lib-external-provisioner/v8 v8.0.0
 )

+require sigs.k8s.io/gateway-api v0.5.1-0.20221110191515-2d586cc49ab4


instead of creating a new require block, can you add it to the block above?

Also is there a release tag of gateway-api we can use?

Also is there a release tag of gateway-api we can use?
There is none.

@robscott
Could you please create a tag that includes the ReferenceGrant API Beta?

msau42 · 2022-11-22T02:13:07Z

pkg/controller/controller.go

@@ -537,6 +544,11 @@ func (p *csiProvisioner) prepareProvision(ctx context.Context, claim *v1.Persist
 		return nil, controller.ProvisioningFinished, errors.New("storage class was nil")
 	}

+	if !utilfeature.DefaultFeatureGate.Enabled(features.CrossNamespaceVolumeDataSource) &&
+		claim.Spec.DataSourceRef != nil && claim.Spec.DataSourceRef.Namespace != nil && len(*claim.Spec.DataSourceRef.Namespace) > 0 {
+		return nil, controller.ProvisioningFinished, fmt.Errorf("error handling for DataSourceRef Type %s with non-empty namespace by Name %s: CrossNamespaceVolumeDataSource feature disabled", claim.Spec.DataSourceRef.Kind, claim.Spec.DataSourceRef.Name)


I think we can simplify the error message to say "dataSourceRef namespace specified but the CrossNamespaceVolumeDataSource feature is disabled"

msau42 · 2022-11-22T02:18:11Z

pkg/controller/controller.go

@@ -582,6 +594,28 @@ func (p *csiProvisioner) prepareProvision(ctx context.Context, claim *v1.Persist
 			}
 		}
 	}
+	if utilfeature.DefaultFeatureGate.Enabled(features.CrossNamespaceVolumeDataSource) {
+		if claim.Spec.DataSourceRef != nil {


This logic looks the same as the DataSource logic. Can we create a common function that takes in Name and Kind?

msau42 · 2022-11-22T02:25:22Z

pkg/controller/controller.go

+			// For now we shouldn't pass other things to this function, but treat it as a noop and extend as needed
+			return nil, nil
+		}
+	} else {


Do we need the if/else? The logic looks exactly the same.

msau42 · 2022-11-22T02:32:49Z

pkg/controller/controller.go

+		return false, nil
+	}
+
+	// Get all ReferenceGrants in snapshot's namespace


update comment to say "data source" instead of "snapshot"

msau42 · 2022-11-22T02:33:51Z

pkg/controller/controller.go

@@ -1081,47 +1175,117 @@ func (p *csiProvisioner) getPVCSource(ctx context.Context, claim *v1.PersistentV
 	return volumeContentSource, nil
 }

+func (p *csiProvisioner) IsGranted(ctx context.Context, claim *v1.PersistentVolumeClaim) (bool, error) {


Add a todo that this function should eventually be replaced by a common kubernetes library

Fixed. https://github.com/kubernetes-csi/external-provisioner/pull/805/files#diff-243ebed2765f75e6a54f57167212fefb08c3b2a85967ad2acbc0eb78919019c1R1121

btw does the gateway controller have a similar method?

msau42 · 2022-11-22T02:40:13Z

pkg/controller/controller.go

+		}
+
+		for _, to := range grant.Spec.To {
+			if claim.Spec.DataSourceRef.APIGroup != nil && (string(to.Group) != *claim.Spec.DataSourceRef.APIGroup || string(to.Kind) != claim.Spec.DataSourceRef.Kind) {


What if dataSourceRef.APIGroup == nil and to.Group is set?

Also it should be groupMatches and kindMatches right?

I fixed it as follows. Is this the fix you expected?
https://github.com/kubernetes-csi/external-provisioner/pull/805/files#diff-243ebed2765f75e6a54f57167212fefb08c3b2a85967ad2acbc0eb78919019c1R1145-R1149

msau42 · 2022-11-22T02:40:50Z

pkg/controller/controller.go

+	}
+
+	if !allowed {
+		return false, nil


I think this could just be return allowed, nil

msau42 · 2022-11-22T02:48:09Z

pkg/controller/controller.go

+	var claim *v1.PersistentVolumeClaim
+	var err error
+
+	if pvc.Spec.DataSourceRef != nil {


How much of this logic can be simplified across all the data sources if we had a common function that can normalize DataSource and DataSourceRef? Something like:

func dataSource(claim *v1.PersistentVolumeClaim) (ObjectReference, error)

I see that this pattern repeats many times for each of the data source types.

I think there is still room for improvement, but I was able to normalize and remove the duplicated code. Is the fix as expected?

Changed to check the featuregate in the dataSource function. Also, since it is confirmed at the beginning of the prepareProvision function, the confirmation of featuregate removed in the "IsGrant ", "getSnapshotSource ", and "getPVCSource " function.

It looks much better now thanks!

ttakahashi21 · 2022-11-30T06:10:39Z

#805 (comment)
I'm sorry. I was mistaken. No error occurs.

msau42 · 2022-11-30T21:27:24Z

pkg/controller/controller.go

+	var claim *v1.PersistentVolumeClaim
+	var err error
+
+	if len(dataSource.Namespace) > 0 {


Can dataSource also set the namespace field so we don't need this check?

It is possible. Fixed code.

msau42 · 2022-11-30T21:28:43Z

pkg/controller/controller.go

+	var err error
+	if len(dataSource.Namespace) > 0 {
+		if claim.Namespace != dataSource.Namespace {
+			if ok, err := p.IsGranted(ctx, claim); err != nil || !ok {


Can IsGranted also be moved to dataSource?

Is it possible. Fixed code.

msau42 · 2022-11-30T21:30:15Z

pkg/controller/controller.go

@@ -1081,47 +1175,117 @@ func (p *csiProvisioner) getPVCSource(ctx context.Context, claim *v1.PersistentV
 	return volumeContentSource, nil
 }

+func (p *csiProvisioner) IsGranted(ctx context.Context, claim *v1.PersistentVolumeClaim) (bool, error) {


btw does the gateway controller have a similar method?

msau42 · 2022-11-30T21:38:08Z

pkg/controller/controller_test.go

+
+	var provisionRequest controller.ProvisionOptions
+	if setnamespace {
+		provisionRequest = controller.ProvisionOptions{


It looks like almost everything is the same and the only difference is the namespace field. I think you can move this out of this if block and only change the namespace inside.

msau42 · 2022-11-30T21:45:41Z

pkg/controller/controller_test.go

 	}

 	for k, tc := range testcases {
 		tc := tc
 		t.Run(k, func(t *testing.T) {
-			t.Parallel()
+			if !tc.xnsEnabled {
+				t.Parallel()


Why does the xns feature require serial tests?

Because the test did not work with feature gate enabled when it was executed in parallel test.

Hm that seems to imply there is some global shared state somewhere. I think it would be good to investigate more into that.

DefaultFeatureGate defined in utilfeature seems a global value, therefore setting value during tests causes changes to a global value in each test.

thanks for investigting, can you add a comment and open an issue so we can track improving this in the future?

I added the link of the issue I created as a comment

msau42 · 2022-11-30T21:47:24Z

pkg/controller/controller_test.go

+							},
+						}
+					}
+				} else {


Can this be collapsed into 2 conditions?

msau42 · 2022-11-30T21:49:14Z

pkg/controller/controller.go

@@ -1081,47 +1118,108 @@ func (p *csiProvisioner) getPVCSource(ctx context.Context, claim *v1.PersistentV
 	return volumeContentSource, nil
 }

+// TODO: This function should eventually be replaced by a common kubernetes library.


For now this is a pretty important function from a security perspective. Can we move this out into a util file and have extensive unit tests for it?

Added new file of util.go and util_test.go on the controller package.

ttakahashi21 · 2022-12-08T19:39:18Z

@msau42
#805 (comment)
I found two similar logics.

[cillum]
https://github.com/cilium/cilium/pull/21902/files#diff-c97054ccf2e8ead85e142ecda08c521b76ce13f924cc79dac145d380cd5bcf13R152-R174

[envoyproxy]
https://github.com/envoyproxy/gateway/pull/172/files#diff-be48a4416dad5f211bed7f15e1cc13e8cdfaa1378a7d5be349d8bb06e4b2054eR706-R745

msau42

Thanks for all the great work! I just have a few unit test suggestions.

msau42 · 2022-12-09T22:53:32Z

pkg/controller/controller_test.go

 	}

 	for k, tc := range testcases {
 		tc := tc
 		t.Run(k, func(t *testing.T) {
-			t.Parallel()
+			if !tc.xnsEnabled {
+				t.Parallel()


thanks for investigting, can you add a comment and open an issue so we can track improving this in the future?

msau42 · 2022-12-09T23:48:10Z

pkg/controller/controller.go

-func (p *csiProvisioner) setCloneFinalizer(ctx context.Context, pvc *v1.PersistentVolumeClaim) error {
-	claim, err := p.claimLister.PersistentVolumeClaims(pvc.Namespace).Get(pvc.Spec.DataSource.Name)
+func (p *csiProvisioner) setCloneFinalizer(ctx context.Context, pvc *v1.PersistentVolumeClaim, dataSource *v1.ObjectReference) error {
+	var claim *v1.PersistentVolumeClaim


Can you restore the original code style, where the variables were defined inline?

msau42 · 2022-12-10T00:34:41Z

pkg/controller/util_test.go

+		volOpts      controller.ProvisionOptions
+		refGrantList []*gatewayv1beta1.ReferenceGrant
+	}
+	testcases := map[string]testcase{


Can you add a test case for nil datasource apigroup?

https://github.com/kubernetes-csi/external-provisioner/pull/805/files#diff-640957054096359bf678ef9f2789673a60814fba8286165ad298f5eba881536aR113-R116

https://github.com/kubernetes-csi/external-provisioner/pull/805/files#diff-640957054096359bf678ef9f2789673a60814fba8286165ad298f5eba881536aR215-R222
I added.

msau42 · 2022-12-10T00:56:24Z

pkg/controller/util_test.go

+	testcases := map[string]testcase{
+		"Allowed to access dataSource for xns PVC with refGrant": {
+			volOpts:      generatePVCForProvisionFromXnsdataSource(toNamespace, fromsrcName, "", pvcapiKind, &fromNamespace, &coreapiGrp, requestedBytes, "", true),
+			refGrantList: newRefGrantList("refGrant1", fromNamespace, coreapiGrp, pvcapiKind, toNamespace, coreapiGrp, pvcapiKind, "", false),


I know we do this in our other test files, but I think it's a little difficult to read the test case with this style of constructor because I need to remember the ordering of the arguments and which field they correspond to. It's perhaps more lines, but I think it's more readable to directly reference the object in the test case definition.

If you want to reduce the boilerplate, maybe you can still have a constructor, but have it take a ReferenceGrantFrom and a ReferenceGrantTo as arguments?

Similar comment for generatePVC... Keep the constructor to reduce on the common boilerplate, but have it take DataSourceRef type as an input, which is what changes across each test case.

util_test.go created a base test case. And I modified the base test case and modified it to add the test case.
Along with the above modifications, TestProvisionFromSnapshot and TestProvisionFromPVC have also been modified.

In util.go I added the following just in case:
https://github.com/kubernetes-csi/external-provisioner/pull/805/files#diff-ded124c02add3467ce103641d0cd28436ea69cf37c5906470b3d519009d950b7R16-R20

As it turned out to be necessary in the test case below.
https://github.com/kubernetes-csi/external-provisioner/pull/805/files#diff-640957054096359bf678ef9f2789673a60814fba8286165ad298f5eba881536aR166-R170

This condition is unnecessary in the controller because it is acquired by specifying the namespace, but I added it just in case.
https://github.com/kubernetes-csi/external-provisioner/pull/805/files#diff-243ebed2765f75e6a54f57167212fefb08c3b2a85967ad2acbc0eb78919019c1R1936-R1937

msau42 · 2022-12-12T22:05:10Z

/lgtm
/approve

Thanks for adding all the comprehensive unit tests!

For the release note, can you update it to say "Add support for cross-namespace data sources alpha feature"

k8s-ci-robot · 2022-12-12T22:05:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, ttakahashi21

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Nov 3, 2022

k8s-ci-robot requested review from humblec and Jiawei0227 November 3, 2022 15:19

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 3, 2022

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 3, 2022

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 3, 2022

ttakahashi21 changed the title ~~Update codes for controller and rbac~~ Alpha support for provision volumes from cross-namespace snapshots Nov 3, 2022

humblec reviewed Nov 4, 2022

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 4, 2022

xing-yang reviewed Nov 4, 2022

View reviewed changes

mkimuram mentioned this pull request Nov 9, 2022

Provision volumes from cross-namespace snapshots kubernetes/enhancements#3294

Closed

9 tasks

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 11, 2022

ttakahashi21 force-pushed the KEP-3294 branch from 3c81e32 to 7f613fb Compare November 12, 2022 23:16

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2022

ttakahashi21 mentioned this pull request Nov 14, 2022

Add document for Provision volumes from cross namespace data sources kubernetes/website#37802

Merged

k8s-ci-robot assigned msau42 Nov 14, 2022

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 14, 2022

msau42 reviewed Nov 15, 2022

View reviewed changes

ttakahashi21 force-pushed the KEP-3294 branch 2 times, most recently from 2b8ea8c to bbd6d77 Compare November 18, 2022 08:08

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 18, 2022

msau42 reviewed Nov 22, 2022

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 23, 2022

ttakahashi21 mentioned this pull request Nov 28, 2022

Add blog post for Provision volumes from cross namespace data sources kubernetes/website#37628

Merged

ttakahashi21 changed the title ~~Alpha support for provision volumes from cross-namespace snapshots~~ Alpha support for provision volumes from cross-namespace data sources Nov 28, 2022

ttakahashi21 force-pushed the KEP-3294 branch from bbd6d77 to aecf95f Compare November 29, 2022 15:28

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2022

ttakahashi21 force-pushed the KEP-3294 branch 2 times, most recently from 59b292e to ef748fe Compare November 30, 2022 05:42

msau42 reviewed Nov 30, 2022

View reviewed changes

ttakahashi21 force-pushed the KEP-3294 branch from 94f465a to 1c69511 Compare December 9, 2022 18:28

msau42 reviewed Dec 10, 2022

View reviewed changes

ttakahashi21 force-pushed the KEP-3294 branch from 1c69511 to f4e3be4 Compare December 11, 2022 01:30

ttakahashi21 mentioned this pull request Dec 11, 2022

Is not working utilfeaturetesting.SetFeatureGateDuringTest for TestProvisionFromPVC Parallel Test #833

Open

ttakahashi21 added 2 commits December 11, 2022 02:49

Alpha support for provision volumes from cross-namespace data sources

f4806b7

Update go.mod go.sum vendor

bbb2698

ttakahashi21 force-pushed the KEP-3294 branch from f4e3be4 to bbb2698 Compare December 11, 2022 02:51

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2022

k8s-ci-robot merged commit df6fe81 into kubernetes-csi:master Dec 12, 2022

mpatlasov mentioned this pull request Jan 30, 2023

STOR-1020: Rebase external-provisioner to v3.4.0 for OCP 4.13 openshift/csi-external-provisioner#60

Merged

ttakahashi21 mentioned this pull request Feb 2, 2023

Add provisioning volumes from cross-namespace data sources kubernetes-csi/lib-volume-populator#72

Closed

ttakahashi21 mentioned this pull request Feb 23, 2023

REQUEST: New membership for ttakahashi21 kubernetes/org#4040

Closed

9 tasks

msau42 mentioned this pull request Mar 17, 2023

Add provisioning volumes from cross-namespace data sources #804

Closed

ttakahashi21 mentioned this pull request Jul 9, 2023

Alpha support for provision volumes from cross-namespace data sources kubernetes-csi/lib-volume-populator#117

Merged

Alpha support for provision volumes from cross-namespace data sources #805

Alpha support for provision volumes from cross-namespace data sources #805

Conversation

ttakahashi21 commented Nov 3, 2022 • edited Loading

k8s-ci-robot commented Nov 3, 2022

k8s-ci-robot commented Nov 3, 2022

humblec Nov 4, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

humblec commented Nov 4, 2022

humblec commented Nov 4, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ttakahashi21 commented Nov 14, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ttakahashi21 commented Nov 30, 2022

Choose a reason for hiding this comment

ttakahashi21 Nov 30, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ttakahashi21 commented Dec 8, 2022

msau42 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ttakahashi21 commented Nov 3, 2022 •

edited

Loading

humblec Nov 4, 2022 •

edited

Loading

ttakahashi21 Nov 30, 2022 •

edited

Loading