Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapshotter 1.x support for configmap leadership election type #168

Closed
ggriffiths opened this issue Sep 6, 2019 · 2 comments
Closed

snapshotter 1.x support for configmap leadership election type #168

ggriffiths opened this issue Sep 6, 2019 · 2 comments

Comments

@ggriffiths
Copy link
Member

Since leases leadership election is only supported in k8s 1.14+, the snapshotter leadership election will not work in k8s 1.13.

Attacher/provisioner sidecars allow non-lease leadership election types in their latest 1.x releases:
https://github.com/kubernetes-csi/external-provisioner/blob/v1.3.0/cmd/csi-provisioner/csi-provisioner.go#L205-L213

https://github.com/kubernetes-csi/external-attacher/blob/release-1.2/cmd/csi-attacher/main.go#L203-L211

@ggriffiths ggriffiths changed the title Snapshotter support for configmap leadership election type snapshotter 1.x support for configmap leadership election type Sep 6, 2019
@msau42
Copy link
Collaborator

msau42 commented Sep 6, 2019

Snapshotter is still alpha so we don't need to follow backwards compatibility and upgrade requirements like attacher and provisioner do. For recommended k8s versions for snapshotter, follow this table: https://kubernetes-csi.github.io/docs/external-snapshotter.html

@ggriffiths
Copy link
Member Author

Makes sense, thanks!

andyzhangx pushed a commit to andyzhangx/external-snapshotter that referenced this issue Jun 5, 2024
Remove requirement to be top-level approver for release
jsafrane pushed a commit to jsafrane/external-snapshotter that referenced this issue Dec 5, 2024
…ncy-openshift-4.19-csi-snapshot-validation-webhook

OCPBUGS-45582: Updating ose-csi-snapshot-validation-webhook-container image to be consistent with ART for 4.19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants