Remove volumesnapshot.spec.source.snapshotHandle field.

[bells17]

It seems that volumesnapshot.spec.source.snapshotHandle is the same field that has meaning as volumesnapshot.spec.snapshotHandle.

And I noticed volumesnapshot.spec.source.snapshotHandle never had any value set.
So now the GetSnapshotStatus method never calls.

external-snapshotter/pkg/sidecar-controller/snapshot_controller.go

Lines 256 to 264 in 4b7aec3

	if content.Spec.Source.SnapshotHandle != nil {
	klog.V(5).Infof("checkandUpdateContentStatusOperation: call GetSnapshotStatus for snapshot which is pre-bound to content [%s]", content.Name)
	readyToUse, creationTime, size, err = ctrl.handler.GetSnapshotStatus(content)
	if err != nil {
	klog.Errorf("checkandUpdateContentStatusOperation: failed to call get snapshot status to check whether snapshot is ready to use %q", err)
	return nil, err
	}
	driverName = content.Spec.Driver
	snapshotID = *content.Spec.Source.SnapshotHandle

So I think that should remove volumesnapshot.spec.source.snapshotHandle field.
(if volumesnapshot.spec.source.snapshotHandle and volumesnapshot.spec.snapshotHandle has another role, please teach me about it 🙏 )

[xing-yang]

Spec.Source.SnapshotHandle in VolumeSnapshotContent is only specified for pre-provisioned snapshots. It indicates a desired state. If you are testing dynamically creating a snapshot, it will be empty. See "Importing an existing volume snapshot with Kubernetes" section in the blog https://kubernetes.io/blog/2019/12/09/kubernetes-1-17-feature-cis-volume-snapshot-beta/.

Status.SnapshotHandle in VolumeSnapshotContent indicates actual state. This field should be populated in both dynamic provisioning and pre-provisioned cases.

[bells17]

Thank you for your describe. I understand.