Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update release-tools to fix spelling error #1105

Merged
merged 4 commits into from
Jun 5, 2024
Merged

chore: update release-tools to fix spelling error #1105

merged 4 commits into from
Jun 5, 2024

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Jun 5, 2024 •
edited
Loading

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
chore: update release-tools to fix spelling error

Squashed 'release-tools/' changes from https://github.com/kubernetes-csi/external-snapshotter/commit/adb3af9dfa3ed4d1a922cd839bb48e0b73918617..https://github.com/kubernetes-csi/external-snapshotter/commit/f40f0ccd458f2d4555e3ca98d69b5a984bae0f14
https://github.com/kubernetes-csi/external-snapshotter/commit/f40f0ccd458f2d4555e3ca98d69b5a984bae0f14 Merge pull request https://github.com/kubernetes-csi/external-snapshotter/pull/256 from solumath/master
https://github.com/kubernetes-csi/external-snapshotter/commit/cfa92106cd9eac6b51e9257b71296a84cc03dbaf Instruction update
https://github.com/kubernetes-csi/external-snapshotter/commit/379a1bb9b001c0d62a091a21f1a4efaf42987248 Merge pull request https://github.com/kubernetes-csi/external-snapshotter/pull/255 from humblec/sidecar-md
https://github.com/kubernetes-csi/external-snapshotter/commit/a5667bbbbf9297bf24afc36ded1bd2a9a8eeb56e fix typo in sidecar release process
https://github.com/kubernetes-csi/external-snapshotter/commit/49676850e1c9c41b263720e1756322d9e35edd73 Merge pull request https://github.com/kubernetes-csi/external-snapshotter/pull/254 from bells17/add-github-actions
https://github.com/kubernetes-csi/external-snapshotter/commit/d9bd160c2a756b1963c333a93953dfb47f7bae72 Update skip list in codespell GitHub Action
https://github.com/kubernetes-csi/external-snapshotter/commit/f5aebfc9f391bd976ce0c3ed28b7d2a91ff602c6 Add GitHub Actions workflows

git-subtree-dir: release-tools
git-subtree-split: https://github.com/kubernetes-csi/external-snapshotter/commit/f40f0ccd458f2d4555e3ca98d69b5a984bae0f14

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

none

andyzhangx added 3 commits June 5, 2024 13:13
@andyzhangx
Squashed 'release-tools/' changes from adb3af9..f40f0cc
5666da4 
f40f0cc Merge pull request kubernetes-csi#256 from solumath/master
cfa9210 Instruction update
379a1bb Merge pull request kubernetes-csi#255 from humblec/sidecar-md
a5667bb fix typo in sidecar release process
4967685 Merge pull request kubernetes-csi#254 from bells17/add-github-actions
d9bd160 Update skip list in codespell GitHub Action
f5aebfc Add GitHub Actions workflows

git-subtree-dir: release-tools
git-subtree-split: f40f0cc
@andyzhangx
Merge commit '5666da4cb775977661307ab0f4c16acb52dd1734'
4ab08f9
@andyzhangx
test: ignore spelling error
9a73243
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Jun 5, 2024
@k8s-ci-robot k8s-ci-robot requested review from humblec and jingxu97 June 5, 2024 13:15
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 5, 2024
@xing-yang
Copy link
Collaborator

Can you add the commit message from this 5666da4 to the PR description so we know that you ran "git subtree"?

@andyzhangx
Copy link
Member Author

Can you add the commit message from this 5666da4 to the PR description so we know that you ran "git subtree"?

done

@xing-yang
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit d505406 into kubernetes-csi:master Jun 5, 2024
8 checks passed
@xing-yang xing-yang mentioned this pull request Aug 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@humblec humblec Awaiting requested review from humblec

@jingxu97 jingxu97 Awaiting requested review from jingxu97

Assignees

@xing-yang xing-yang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyzhangx @xing-yang @k8s-ci-robot