Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prow testing #111

Merged
merged 40 commits into from
Apr 15, 2019
Merged

Prow testing #111

merged 40 commits into from
Apr 15, 2019

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Apr 8, 2019 •
edited
Loading

This imports csi-release-tools (unchanged copy) and adds a .prow.sh file in 944be88.

pohly and others added 20 commits March 6, 2019 17:23
@pohly
verify-subtree.sh: relax check and ignore old content
cc564f9 
If for whatever reasons a repo already had a `release-tools` directory
before doing a clean import of it with `git subtree`, the check used
to fail because it found those old commits.

This can be fixed by telling `git log` to stop when the directory
disappears from the repo. There has to be a commit with removes the
old content, because otherwise `git subtree add` doesn't work.

Fixes: kubernetes-csi/external-resizer#21
@k8s-ci-robot
Merge pull request kubernetes-csi#8 from pohly/subtree-check-relax
849db0a 
verify-subtree.sh: relax check and ignore old content
@pohly
build.make: avoid unit-testing E2E test suite
94fc1e3 
In repos that have a test/e2e, that test suite should be run
separately because it depends on a running cluster.
@pohly
verify-shellcheck.sh: import from Kubernetes
fb13c51 
This is an unmodified copy of kubernetes/hack/verify-shellcheck.sh
revision d5a3db003916b1d33b503ccd2e4897e094d8af77.
@pohly
check vendor directory
e6db50d 
This runs "dep check" to verify that the vendor directory is
up-to-date and meets expectations (= done with dep >= 0.5.0).
@k8s-ci-robot
Merge pull request kubernetes-csi#10 from pohly/vendor-check
34010e7 
check vendor directory
@pohly
build.make: avoid unit-testing E2E test suite
104a1ac 
In repos that have a test/e2e, that test suite should be run
separately because it depends on a running cluster.
@k8s-ci-robot
Merge pull request kubernetes-csi#12 from pohly/local-e2e-suite
3b6af7b 
build.make: avoid unit-testing E2E test suite
@pohly
verify-shellcheck.sh: make it usable in csi-release-tools
b2d25d4 
These are the modifications that were necessary to call this outside
of Kubernetes. The support for excluding files from checking gets
removed to simplify the script. It shouldn't be needed, because
linting can be enabled after fixing whatever scripts might fail the
check.
@pohly
build.make: integrate shellcheck into "make test"
6c7ba1b 
By default this only tests the scripts inside the "release-tools"
directory, which is useful when making experimental changes to them in
a component that uses csi-release-tools. But a component can also
enable checking for other directories.
@pohly
initial Prow test job
55212ff 
This enables testing of other repos and of this repo itself inside
Prow. Currently supported is unit testing ("make test") and E2E
testing (either via a local test suite or the Kubernetes E2E test
suite applied to the hostpath driver example deployment).

The script passes shellcheck and uses Prow to verify that for future
PRs.
@k8s-ci-robot
Merge pull request kubernetes-csi#11 from pohly/verify-shellcheck
2069a0a 
verify shellcheck
@pohly
prow.sh: comment clarification
0a0fd49
@pohly
prow.sh: pull Go version from travis.yml
429581c 
The travis.yml is now the only place where the Go version for the
component itself needs to be configured.
@pohly
prow.sh: take Go version from Kubernetes source
29545bb 
Using the same (recent) Go version for all Kubernetes versions can
break for older versions when there are incompatible changes in Go. To
avoid that, we use exactly the minimum version of Go required for each
Kubernetes version. This is based on the assumption that this
combination was tested successfully.

When building the E2E suite from Kubernetes (the default) we do the
same, but still allow building it from elsewhere.

We allow the Go version to be empty when it doesn't matter.
@pohly
prow.sh: improve building Kubernetes from source
741319b 
While switching back and forth between release-1.13 and release-1.14
locally, there was the problem that the local kind image kept using
the wrong kubelet binary despite rebuilding from source. The problem
went away after cleaning the Bazel cache. Exact root cause unknown,
but perhaps using unique tags and properly cleaning the repo helps.

If not, then the unique tags at least will show what the problem is.
@pohly
prow.sh: different E2E suite depending on Kubernetes version
6602d38 
Instead of always using the latest E2E tests for all Kubernetes
versions, the plan now is to use the tests that match the Kubernetes
version. However, for 1.13 we have to make an exception because the
suite for that version did not support the necessary
--storage.testdriver parameter.
@pohly
prow.sh: switch back to upstream csi-driver-host-path
d87eccb 
The temporary fork was merged, we can use the upstream repo again.
@k8s-ci-robot
Merge pull request kubernetes-csi#9 from pohly/prow
95ae9de 
Prow testing
@pohly
.prow.sh: enable Prow testing
944be88
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2019
@k8s-ci-robot k8s-ci-robot requested review from msau42 and saad-ali April 8, 2019 09:28
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 8, 2019
@pohly
Copy link
Contributor Author

pohly commented Apr 8, 2019

/test pull-sig-storage-external-attacher-1-13-on-kubernetes-1-13

@pohly
Copy link
Contributor Author

pohly commented Apr 8, 2019

/hold

kubernetes/test-infra#12088 has to be merged first

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2019
@pohly
Copy link
Contributor Author

pohly commented Apr 8, 2019

/test pull-sig-storage-external-snapshotter

@pohly
prow.sh: AllAlpha=true for unknown Kubernetes versions
f501443 
This ensures that also new, currently unknown alpha gates are enabled
when testing against a future Kubernetes versions. For all currently
known Kubernetes versions we just use the minimal set of alpha gates,
which ensures that we don't miss any of them in our documentation.
@pohly
Copy link
Contributor Author

pohly commented Apr 11, 2019

/test pull-kubernetes-csi-external-snapshotter
/test pull-kubernetes-csi-external-snapshotter-unit
/test pull-kubernetes-csi-external-snapshotter-alpha

pohly and others added 3 commits April 11, 2019 13:37
@pohly
prow.sh: update csi-driver-host-path
0b10f6a 
This pulls in
kubernetes-csi/csi-driver-host-path#37, which
turned out to be necessary for pre-submit testing of the
livenessprobe.
@k8s-ci-robot
Merge pull request kubernetes-csi#16 from pohly/prow
bcac1c1 
prow.sh: update csi-driver-host-path
@pohly
Merge commit 'bcac1c1fb6d791fe54a84716a5fdcccd0987a351' into prow
85f85cd
@pohly
Copy link
Contributor Author

pohly commented Apr 11, 2019

/test pull-kubernetes-csi-external-snapshotter
/test pull-kubernetes-csi-external-snapshotter-unit
/test pull-kubernetes-csi-external-snapshotter-alpha

@pohly pohly changed the title Prow testing WIP: Prow testing Apr 11, 2019
pohly and others added 3 commits April 11, 2019 22:32
@pohly
prow.sh: skip sanity testing if component doesn't support it
0fafc66 
Whether a component supports sanity testing depends on the
component. For example, csi-driver-host-path enables it because it
makes sense there (and only there). Letting the prow.sh script decide
whether it actually runs simplifies the job definitions in test-infra.
@k8s-ci-robot
Merge pull request kubernetes-csi#17 from pohly/prow
88dc9a4 
prow.sh: skip sanity testing if component doesn't support it
@pohly
Merge commit '88dc9a47e5aa627fc28179087d8ee1caeb40ecac' into prow
7f6e317
@pohly
Copy link
Contributor Author

pohly commented Apr 12, 2019

/test pull-kubernetes-csi-external-snapshotter
/test pull-kubernetes-csi-external-snapshotter-unit
/test pull-kubernetes-csi-external-snapshotter-alpha

@pohly pohly changed the title WIP: Prow testing Prow testing Apr 12, 2019
@msau42
Copy link
Collaborator

msau42 commented Apr 12, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2019
@msau42
Copy link
Collaborator

msau42 commented Apr 12, 2019

/assign @xing-yang

xing-yang
xing-yang reviewed Apr 15, 2019
View reviewed changes
Copy link
Collaborator

@xing-yang xing-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits, otherwise looks good to me.

release-tools/util.sh
@@ -0,0 +1,148 @@
#!/usr/bin/env bash

# Copyright 2014 The Kubernetes Authors.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should be 2019

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original code actually is from 2014. I just copied it.

release-tools/verify-shellcheck.sh
@@ -0,0 +1,146 @@
#!/usr/bin/env bash

# Copyright 2018 The Kubernetes Authors.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2019

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@pohly
Copy link
Contributor Author

pohly commented Apr 15, 2019

@xing-yang I can't change these commits here. They are verbatim copies from https://github.com/kubernetes-csi/csi-release-tools/commits/master

If you want to review such changes before they are merged, then I can add you as reviewer of future changes in that repo.

If you see something that absolutely has to be changed now, then we'll have to treat that as bugs against csi-release-tools. But these nits are probably something that we can leave unchanged. Agreed?

@xing-yang
Copy link
Collaborator

@pohly If these are copies from https://github.com/kubernetes-csi/csi-release-tools/commits/master and cannot be changed in this repo, can you add some description at the top of this PR to clarify that?

@pohly
Copy link
Contributor Author

pohly commented Apr 15, 2019

If these are copies from https://github.com/kubernetes-csi/csi-release-tools/commits/master and cannot be changed in this repo, can you add some description at the top of this PR to clarify that?

I was assuming that component maintainers are familiar with how csi-release-tools (= release-tools in each component) is maintained. But sure, I can add something.

@xing-yang
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 22a67f3 into kubernetes-csi:master Apr 15, 2019
xing-yang added a commit to xing-yang/external-snapshotter that referenced this pull request Nov 14, 2020
@xing-yang
Squashed 'release-tools/' changes from 4aff857..5d874cc
fae1421 
5d874cc Merge pull request kubernetes-csi#112 from xing-yang/cleanup
79bbca7 Cleanup
d437673 Merge pull request kubernetes-csi#111 from xing-yang/update_snapshot_v1_rc
57718f8 Update snapshot CRD version

git-subtree-dir: release-tools
git-subtree-split: 5d874cc
@xing-yang xing-yang mentioned this pull request Nov 14, 2020
Merged
ggriffiths pushed a commit to ggriffiths/external-snapshotter that referenced this pull request Dec 3, 2020
@k8s-ci-robot
Merge pull request kubernetes-csi#111 from xing-yang/update_snapshot_…
d437673 
…v1_rc

Update snapshot CRD version
ggriffiths added a commit to ggriffiths/external-snapshotter that referenced this pull request Dec 3, 2020
@ggriffiths
Squashed 'release-tools/' changes from 3041b8a..86ff580
ea8215f 
86ff580 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name
c3a9662 allow export image name and registry name
c6a88c6 Merge pull request kubernetes-csi#113 from xing-yang/install_snapshot_controller
45ec4c6 Fix the install of snapshot CRDs and controller
5d874cc Merge pull request kubernetes-csi#112 from xing-yang/cleanup
79bbca7 Cleanup
d437673 Merge pull request kubernetes-csi#111 from xing-yang/update_snapshot_v1_rc
57718f8 Update snapshot CRD version
4aff857 Merge pull request kubernetes-csi#109 from pohly/alpha-test-defaults
0427289 Merge pull request kubernetes-csi#110 from pohly/kind-0.9-bazel-build-workaround
9a370ab prow.sh: work around "kind build node-image" failure
522361e prow.sh: only run alpha tests for latest Kubernetes release
22c0395 Merge pull request kubernetes-csi#108 from bnrjee/master
b5b447b Add go ldflags using LDFLAGS at the time of compilation
16f4afb Merge pull request kubernetes-csi#107 from pohly/kind-update
7bcee13 prow.sh: update to kind 0.9, support Kubernetes 1.19
df518fb prow.sh: usage of Bazel optional
c3afd42 Merge pull request kubernetes-csi#104 from xing-yang/snapshot
dde93b2 Update to snapshot-controller v3.0.0
a0f195c Merge pull request kubernetes-csi#106 from msau42/fix-canary
7100c12 Only set staging registry when running canary job
b3c65f9 Merge pull request kubernetes-csi#99 from msau42/add-release-process
e53f3e8 Merge pull request kubernetes-csi#103 from msau42/fix-canary
d129462 Document new method for adding CI jobs are new K8s versions
e73c2ce Use staging registry for canary tests
2c09846 Add cleanup instructions to release-notes generation
60e1cd3 Merge pull request kubernetes-csi#98 from pohly/kubernetes-1-19-fixes
0979c09 prow.sh: fix E2E suite for Kubernetes >= 1.18
3b4a2f1 prow.sh: fix installing Go for Kubernetes 1.19.0
1fbb636 Merge pull request kubernetes-csi#97 from pohly/go-1.15
82d108a switch to Go 1.15
d8a2530 Merge pull request kubernetes-csi#95 from msau42/add-release-process
843bddc Add steps on promoting release images
0345a83 Merge pull request kubernetes-csi#94 from linux-on-ibm-z/bump-timeout
1fdf2d5 cloud build: bump timeout in Prow job
41ec6d1 Merge pull request kubernetes-csi#93 from animeshk08/patch-1
5a54e67 filter-junit: Fix gofmt error
0676fcb Merge pull request kubernetes-csi#92 from animeshk08/patch-1
36ea4ff filter-junit: Fix golint error
f5a4203 Merge pull request kubernetes-csi#91 from cyb70289/arm64
43e50d6 prow.sh: enable building arm64 image
0d5bd84 Merge pull request kubernetes-csi#90 from pohly/k8s-staging-sig-storage
3df86b7 cloud build: k8s-staging-sig-storage
c5fd961 Merge pull request kubernetes-csi#89 from pohly/cloud-build-binfmt
db0c2a7 cloud build: initialize support for running commands in Dockerfile
be902f4 Merge pull request kubernetes-csi#88 from pohly/multiarch-windows-fix
340e082 build.make: optional inclusion of Windows in multiarch images
5231f05 build.make: properly declare push-multiarch
4569f27 build.make: fix push-multiarch ambiguity
17dde9e Merge pull request kubernetes-csi#87 from pohly/cloud-build
bd41690 cloud build: initial set of shared files
9084fec Merge pull request kubernetes-csi#81 from msau42/add-release-process
6f2322e Update patch release notes generation command
0fcc3b1 Merge pull request kubernetes-csi#78 from ggriffiths/fix_csi_snapshotter_rbac_version_set
d8c76fe Support local snapshot RBAC for pull jobs
c1bdf5b Merge pull request kubernetes-csi#80 from msau42/add-release-process
ea1f94a update release tools instructions
152396e Merge pull request kubernetes-csi#77 from ggriffiths/snapshotter201_update
7edc146 Update snapshotter to version 2.0.1
4cf843f Merge pull request kubernetes-csi#76 from pohly/build-targets
3863a0f build for multiple platforms only in CI, add s390x
8322a7d Merge pull request kubernetes-csi#72 from pohly/hostpath-update
7c5a89c prow.sh: use 1.3.0 hostpath driver for testing
b8587b2 Merge pull request kubernetes-csi#71 from wozniakjan/test-vet
fdb3218 Change 'make test-vet' to call 'go vet'
d717c8c Merge pull request kubernetes-csi#69 from pohly/test-driver-config
a1432bc Merge pull request kubernetes-csi#70 from pohly/kubelet-feature-gates
5f74333 prow.sh: also configure feature gates for kubelet
84f78b1 prow.sh: generic driver installation
3c34b4f Merge pull request kubernetes-csi#67 from windayski/fix-link
fa90abd fix incorrect link
ff3cc3f Merge pull request kubernetes-csi#54 from msau42/add-release-process
ac8a021 Document the process for releasing a new sidecar
23be652 Merge pull request kubernetes-csi#65 from msau42/update-hostpath
6582f2f Update hostpath driver version to get fix for connection-timeout
4cc9174 Merge pull request kubernetes-csi#64 from ggriffiths/snapshotter_2_version_update
8191eab Update snapshotter to version v2.0.0
3c463fb Merge pull request kubernetes-csi#61 from msau42/enable-snapshots
8b0316c Fix overriding of junit results by using unique names for each e2e run
5f444b8 Merge pull request kubernetes-csi#60 from saad-ali/updateHostpathVersion
af9549b Update prow hostpath driver version to 1.3.0-rc2
f6c74b3 Merge pull request kubernetes-csi#57 from ggriffiths/version_gt_kubernetes_fix
fc80975 Fix version_gt to work with kubernetes prefix
9f1f3dd Merge pull request kubernetes-csi#56 from msau42/enable-snapshots
b98b2ae Enable snapshot tests in 1.17 to be run in non-alpha jobs.
9ace020 Merge pull request kubernetes-csi#52 from msau42/update-readme
540599b Merge pull request kubernetes-csi#53 from msau42/fix-make
a4e6299 fix syntax for ppc64le build
771ca6f Merge pull request kubernetes-csi#49 from ggriffiths/prowsh_improve_version_gt
d7c69d2 Merge pull request kubernetes-csi#51 from msau42/enable-multinode
4ad6949 Improve snapshot pod running checks and improve version_gt
53888ae Improve README by adding an explicit Kubernetes dependency section
9a7a685 Create a kind cluster with two worker nodes so that the topology feature can be tested. Test cases that test accessing volumes from multiple nodes need to be skipped
4ff2f5f Merge pull request kubernetes-csi#50 from darkowlzz/kind-0.6.0
80bba1f Use kind v0.6.0
6d674a7 Merge pull request kubernetes-csi#47 from Pensu/multi-arch
8adde49 Merge pull request kubernetes-csi#45 from ggriffiths/snapshot_beta_crds
003c14b Add snapshotter CRDs after cluster setup
a41f386 Merge pull request kubernetes-csi#46 from mucahitkurt/kind-cluster-cleanup
1eaaaa1 Delete kind cluster after tests run.
83a4ef1 Adding build for ppc64le
4fcafec Merge pull request kubernetes-csi#43 from pohly/system-pod-logging
f41c135 prow.sh: also log output of system containers
ee22a9c Merge pull request kubernetes-csi#42 from pohly/use-vendor-dir
8067845 travis.yml: also use vendor directory
23df4ae prow.sh: use vendor directory if available
a53bd4c Merge pull request kubernetes-csi#41 from pohly/go-version
c8a1c4a better handling of Go version
5e773d2 update CI to use Go 1.13.3
f419d74 Merge pull request kubernetes-csi#40 from msau42/add-1.16
e0fde8c Add new variables for 1.16 and remove 1.13
adf00fe Merge pull request kubernetes-csi#36 from msau42/full-clone
f1697d2 Do full git clones in travis. Shallow clones are causing test-subtree errors when the depth is exactly 50.
2c81919 Merge pull request kubernetes-csi#34 from pohly/go-mod-tidy
518d6af Merge pull request kubernetes-csi#35 from ddebroy/winbld2
2d6b3ce Build Windows only for amd64
c1078a6 go-get-kubernetes.sh: automate Kubernetes dependency handling
194289a update Go mod support
0affdf9 Merge pull request kubernetes-csi#33 from gnufied/enable-hostpath-expansion
6208f6a Enable hostpath expansion
6ecaa76 Merge pull request kubernetes-csi#30 from msau42/fix-windows
ea2f1b5 build windows binaries with .exe suffix
2d33550 Merge pull request kubernetes-csi#29 from mucahitkurt/create-2-node-kind-cluster
a8ea8bc create 2-node kind cluster since topology support is added to hostpath driver
df8530d Merge pull request kubernetes-csi#27 from pohly/dep-vendor-check
35ceaed prow.sh: install dep if needed
f85ab5a Merge pull request kubernetes-csi#26 from ddebroy/windows1
9fba09b Add rule for building Windows binaries
0400867 Merge pull request kubernetes-csi#25 from msau42/fix-master-jobs
dc0a5d8 Update kind to v0.5.0
aa85b82 Merge pull request kubernetes-csi#23 from msau42/fix-master-jobs
f46191d Kubernetes master changed the way that releases are tagged, which needed changes to kind. There are 3 changes made to prow.sh:
1cac3af Merge pull request kubernetes-csi#22 from msau42/add-1.15-jobs
0c0dc30 prow.sh: tag master images with a large version number
f4f73ce Merge pull request kubernetes-csi#21 from msau42/add-1.15-jobs
4e31f07 Change default hostpath driver name to hostpath.csi.k8s.io
4b6fa4a Update hostpath version for sidecar testing to v1.2.0-rc2
ecc7918 Update kind to v0.4.0. This requires overriding Kubernetes versions with specific patch versions that kind 0.4.0 supports. Also, feature gate setting is only supported on 1.15+ due to kind.sigs.k8s.io/v1alpha3 and kubeadm.k8s.io/v1beta2 dependencies.
a6f21d4 Add variables for 1.15
db8abb6 Merge pull request kubernetes-csi#20 from pohly/test-driver-config
b2f4e05 prow.sh: flexible test driver config
0399988 Merge pull request kubernetes-csi#19 from pohly/go-mod-vendor
066143d build.make: allow repos to use 'go mod' for vendoring
0bee749 Merge pull request kubernetes-csi#18 from pohly/go-version
e157b6b update to Go 1.12.4
88dc9a4 Merge pull request kubernetes-csi#17 from pohly/prow
0fafc66 prow.sh: skip sanity testing if component doesn't support it
bcac1c1 Merge pull request kubernetes-csi#16 from pohly/prow
0b10f6a prow.sh: update csi-driver-host-path
0c2677e Merge pull request kubernetes-csi#15 from pengzhisun/master
ff9bce4 Replace 'return' to 'exit' to fix shellcheck error
c60f382 Merge pull request kubernetes-csi#14 from pohly/prow
7aaac22 prow.sh: remove AllAlpha=all, part II
6617773 Merge pull request kubernetes-csi#13 from pohly/prow
cda2fc5 prow.sh: avoid AllAlpha=true
546d550 prow.sh: debug failing KinD cluster creation
9b0d9cd build.make: skip shellcheck if Docker is not available
aa45a1c prow.sh: more efficient execution of individual tests
f3d1d2d prow.sh: fix hostpath driver version check
31dfaf3 prow.sh: fix running of just "alpha" tests
f501443 prow.sh: AllAlpha=true for unknown Kubernetes versions
95ae9de Merge pull request kubernetes-csi#9 from pohly/prow
d87eccb prow.sh: switch back to upstream csi-driver-host-path
6602d38 prow.sh: different E2E suite depending on Kubernetes version
741319b prow.sh: improve building Kubernetes from source
29545bb prow.sh: take Go version from Kubernetes source
429581c prow.sh: pull Go version from travis.yml
0a0fd49 prow.sh: comment clarification
2069a0a Merge pull request kubernetes-csi#11 from pohly/verify-shellcheck
55212ff initial Prow test job
6c7ba1b build.make: integrate shellcheck into "make test"
b2d25d4 verify-shellcheck.sh: make it usable in csi-release-tools
3b6af7b Merge pull request kubernetes-csi#12 from pohly/local-e2e-suite
104a1ac build.make: avoid unit-testing E2E test suite
34010e7 Merge pull request kubernetes-csi#10 from pohly/vendor-check
e6db50d check vendor directory
fb13c51 verify-shellcheck.sh: import from Kubernetes
94fc1e3 build.make: avoid unit-testing E2E test suite
849db0a Merge pull request kubernetes-csi#8 from pohly/subtree-check-relax
cc564f9 verify-subtree.sh: relax check and ignore old content
33d58fd Merge pull request kubernetes-csi#5 from pohly/test-enhancements
be8a440 Merge pull request kubernetes-csi#4 from pohly/canary-fix
b0336b5 build.make: more readable "make test" output
09436b9 build.make: fix pushing of "canary" image from master branch
147892c build.make: support suppressing checks
154e33d build.make: clarify usage of "make V=1"

git-subtree-dir: release-tools
git-subtree-split: 86ff580
@ggriffiths ggriffiths mentioned this pull request Dec 5, 2020
Merged
kaovilai pushed a commit to kaovilai/external-snapshotter that referenced this pull request Feb 7, 2024
@openshift-ci
Merge pull request kubernetes-csi#111 from dobsonj/CVE-2023-44487-ori…
7f04d8a 
…gin-release-4.12

[release-4.12] OCPBUGS-20991: CVE-2023-44487: bump golang.org/x/net to v0.17.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@msau42 msau42 Awaiting requested review from msau42

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@xing-yang xing-yang

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pohly @msau42 @xing-yang @k8s-ci-robot @pengzhisun