Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add secrets for Get VolumeGroupSnapshot #1173

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Add secrets for Get VolumeGroupSnapshot #1173

merged 1 commit into from
Nov 15, 2024

Conversation

yati1998
Copy link
Contributor

@yati1998 yati1998 commented Oct 25, 2024 •
edited
Loading

this commit adds new parameter keys for
getvolumegroupsnapshot

Ref: #1122 (comment)

Add VolumeGroupSnapshotClass secrets for GetVolumeGroupSnapshot.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Oct 25, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 25, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @yati1998. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 25, 2024
xing-yang
xing-yang reviewed Oct 25, 2024
View reviewed changes
pkg/utils/util.go Outdated Show resolved Hide resolved
@xing-yang
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 25, 2024
@xing-yang
Copy link
Collaborator

Can you add a release note?

@xing-yang
Copy link
Collaborator

release note: Add VolumeGroupSnapshotClass secrets for GetVolumeGroupSnapshot.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 29, 2024
xing-yang
xing-yang reviewed Oct 29, 2024
View reviewed changes
pkg/utils/util.go Outdated Show resolved Hide resolved
pkg/utils/util.go Outdated Show resolved Hide resolved
pkg/utils/util.go Outdated Show resolved Hide resolved
pkg/utils/util.go Outdated Show resolved Hide resolved
@yati1998
add paramter for list groupsnapshot
722c022 
this commit adds new parameter keys for
getvolumegroupsnapshot

Signed-off-by: yati1998 <ypadia@redhat.com>
@xing-yang xing-yang changed the title add paramter for list groupsnapshot Add secrets for Get VolumeGroupSnapshot Oct 31, 2024
@xing-yang
Copy link
Collaborator

@yati1998 Can you test static provisioning with this PR? This code path will be executed for static provisioning.

@yati1998
Copy link
Contributor Author

yati1998 commented Nov 7, 2024

@xing-yang I am working on testing the static provisioning with this PR, but is there any other changes that needs to be done here?

@yati1998
Copy link
Contributor Author

@yati1998 Can you test static provisioning with this PR? This code path will be executed for static provisioning.

I have tested static provisioning on top of this PR, I dont see any breaking change, we are good to go on this

@nixpanic
Copy link
Member

/lgtm

Tested static provisioning with Ceph-CSI and RBD. This was done with a VolumeGroupSnapshotClass that only sets csi.storage.k8s.io/group-snapshotter-get-secret-name and csi.storage.k8s.io/group-snapshotter-get-secret-namespace.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2024
@nixpanic
Copy link
Member

/unassign
/assign xing-yang

@xing-yang
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xing-yang, yati1998

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3aefaf5 into kubernetes-csi:master Nov 15, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humblec humblec Awaiting requested review from humblec

@pohly pohly Awaiting requested review from pohly

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@xing-yang xing-yang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yati1998 @k8s-ci-robot @xing-yang @nixpanic