Dont call DeleteSnapshot when VS belong to VGS #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
cncf-cla: yes
|
/hold for testing |
k8s-ci-robot
added
do-not-merge/hold
Driver |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/assign @xing-yang @jsafrane |
gnufied
reviewed
Dec 3, 2024
| @@ -61,7 +61,7 @@ func (ctrl *csiSnapshotSideCarController) syncContent(content *crdv1.VolumeSnaps | |||
| if ctrl.shouldDelete(content) { | |||
| klog.V(4).Infof("VolumeSnapshotContent[%s]: the policy is %s", content.Name, content.Spec.DeletionPolicy) | |||
| if content.Spec.DeletionPolicy == crdv1.VolumeSnapshotContentDelete && | |||
| content.Status != nil && content.Status.SnapshotHandle != nil { | |||
| content.Status != nil && content.Status.SnapshotHandle != nil && content.Status.VolumeGroupSnapshotHandle == nil { | |||
There was a problem hiding this comment.
added extra test case to ensure no RPC call is made when VolumeGroupSnapshotHandle is set on the content
k8s-ci-robot
added
size/M
Madhu-1
force-pushed
the
fix-1230
branch
2 times, most recently
from
edf77b6 to
fd45362
Compare
Dont call the DeleteSnapshot RPC call when a snapshot is created as part of the VolumeGroupSnapshot.
6 tasks
gnufied
reviewed
Dec 4, 2024
| for _, c := range content { | ||
| c.Status.VolumeGroupSnapshotHandle = &volumeGroupSnapshotHandle | ||
| } | ||
| return content |
There was a problem hiding this comment.
nit: I personally do not like functions that take this many parmaeters. There are better ways of doing this. Such as - using the builder pattern or using parameter types.
There was a problem hiding this comment.
@gnufied Yes i agree that this is going to make the life harder (read/maintain) but that required more work outside the scope of this PR as lot of cleanup is required in this file, is it accepted to do this cleanup as a followup?
There was a problem hiding this comment.
Can you file an issue for this?
There was a problem hiding this comment.
filed one here #1232
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Madhu-1, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Dont call the DeleteSnapshot RPC call when a snapshot is created as part of the VolumeGroupSnapshot.
Which issue(s) this PR fixes:
Fixes #1230
Special notes for your reviewer:
Does this PR introduce a user-facing change?: