Check if PVC is being used by a snapshot as source #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/assign @yuxiangqian |
xing-yang
force-pushed
the
check_pvc_inuse
branch
from
25bc7b8 to
5cf02f2
Compare
k8s-ci-robot
added
size/M
|
@yuxiangqian This PR is ready for review now. |
yuxiangqian
reviewed
Apr 1, 2020
xing-yang
force-pushed
the
check_pvc_inuse
branch
from
5cf02f2 to
c82c8e0
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes a problem when the PVC finalizer is not removed when it is no longer used by a snapshot as source.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
To reproduce this problem, create snapshot, immediately delete the snapshot before create snapshot has completed. Snapshot will be created and then deleted, but the source PVC can't be deleted because the PVC finalizer is not removed.
This PR fixes the problem.
Does this PR introduce a user-facing change?: