Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump csi-lib-utils to v0.9.0 #439

Merged
merged 2 commits into from
Dec 7, 2020
Merged

Bump csi-lib-utils to v0.9.0 #439

merged 2 commits into from
Dec 7, 2020

Conversation

xing-yang
Copy link
Collaborator

@xing-yang xing-yang commented Dec 4, 2020 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Bump csi-lib-utils to v0.9.0 to get rid of klogv1 and get health check on leader election.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

* Added leader election health check at the metrics port + path "/healthz/leader-election".
* klog/v2 is used for logging
* `metrics-address` flag is deprecated and replaced by `http-endpoint`, which enables handlers from both metrics manager and leader election health check.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 4, 2020
@xing-yang xing-yang changed the title Csi lib utils 0.9 Bump csi-lib-utils to v0.9.0 Dec 4, 2020
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 4, 2020
@xing-yang
Copy link
Collaborator Author

/assign @msau42
/assign @pohly

msau42
msau42 reviewed Dec 4, 2020
View reviewed changes
README.md Outdated
@@ -106,7 +106,7 @@ Read more about how to install the example webhook [here](deploy/kubernetes/webh

* `--leader-election-namespace <namespace>`: The namespace where the leader election resource exists. Defaults to the pod namespace if not set.

* `--metrics-address`: The TCP network address where the prometheus metrics endpoint will run (example: `:8080` which corresponds to port 8080 on local host). The default is empty string, which means metrics endpoint is disabled.
* `--metrics-address`: The TCP network address where the prometheus metrics endpoint and leader election health check will run (example: `:8080` which corresponds to port 8080 on local host). The default is empty string, which means metrics endpoint and leader election check are disabled.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also incorporate the changes that @verult did in kubernetes-csi/external-attacher#279?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This contains the latest changes around the HTTP endpoint: kubernetes-csi/external-provisioner#537

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

msau42
msau42 reviewed Dec 4, 2020
View reviewed changes
cmd/csi-snapshotter/main.go Outdated

// Prepare http endpoint for metrics + leader election healthz
mux := http.NewServeMux()
cmm := metrics.NewCSIMetricsManagerForSidecar(driverName)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is the correct sequence:
https://github.com/kubernetes-csi/external-attacher/pull/278/files

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@msau42
Copy link
Collaborator

msau42 commented Dec 7, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2020
@msau42
Copy link
Collaborator

msau42 commented Dec 7, 2020

Can you also add the other points in the release note from kubernetes-csi/external-provisioner#537?

@xing-yang
Copy link
Collaborator Author

Can you also add the other points in the release note from kubernetes-csi/external-provisioner#537?

Sure

@k8s-ci-robot k8s-ci-robot merged commit 29eced0 into kubernetes-csi:master Dec 7, 2020
@msau42 msau42 mentioned this pull request Dec 16, 2020
Merged
@chrishenzie chrishenzie mentioned this pull request Mar 11, 2021
Closed
@chrishenzie chrishenzie mentioned this pull request May 1, 2021
Merged
k8s-ci-robot added a commit that referenced this pull request May 3, 2021
@k8s-ci-robot
Merge pull request #511 from chrishenzie/release-3.1-http-endpoint
f63ca22 
Cherry-picks of #409 and #439: Adding --http-endpoint to snapshot components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@verult verult verult left review comments

@lpabon lpabon Awaiting requested review from lpabon

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@pohly pohly

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xing-yang @k8s-ci-robot @msau42 @verult @pohly