Make passing Travis required for merge

[saad-ali]

Make passing Travis required for merge

xref kubernetes/test-infra#9014 (comment)

/assign @sbezverk

[sbezverk]

@saad-ali to really test it that would require a k8s cluster or minikube, should I add a sort of integration test, brining k8s and then starting liveness probe?

[jsafrane]

Travis runs go vet, make, gofmt and go test, all this is great to have (and it should succeed before merge). However, I don't see any real tests. go test does not run anything.

So yes, let's make travis mandatory, but also let's prepare real tests. Liveness probe is a simple executable that talks to CSI driver and returns error when Probe() fails. All this can be tested outside of Kubernetes easily with a mock CSI driver.

[sbezverk]

@jsafrane I can add a small script to travis to start hostpath driver and liveness probe and check the result of a probe. Would it be sufficient for testing?

[jsafrane]

Yes, that's a good start. And a script that runs just the probe and no driver (-> timeout or connection refused? -> nozero exit code) should be easy too and it would cover one error case.

[spiffxp]

When you're ready to implement this, open a PR to https://github.com/kubernetes/test-infra/blob/master/prow/config.yaml

eg: for kubernetes-csi/external-attacher https://github.com/kubernetes/test-infra/blob/master/prow/config.yaml#L172-L175

[sbezverk]

@spiffxp PTAL kubernetes/test-infra#9051