add --timeout for gRPC calls #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/XS
|
/retest |
1 similar comment
|
/retest |
This was referenced Dec 4, 2020
k8s-ci-robot
added
the
needs-rebase
The one second timeout is based on the assumption that once the connection is established, all further communication is going to be fast. That assumption doesn't hold in some special circumstances: - interactively debugging the sidecar - proxying the driver operation to some remote implementation While this is a bit obscure, the flag is essential for these cases. Adding the flag also makes the node-driver-registrar consistent with other sidecars.
k8s-ci-robot
removed
the
needs-rebase
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @jsafrane For approval. |
|
/assign @msau42 Looks like Jan is busy today, let's see whether Michelle has time for the final approval... |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jiawei0227, jsafrane, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
pohly
added a commit
to pohly/node-driver-registrar
that referenced
this pull request
Jan 26, 2021
1d60e779 Merge pull request kubernetes-csi#131 from pohly/kubernetes-1.20-tag 9f104590 prow.sh: support building Kubernetes for a specific version fe1f2848 Merge pull request kubernetes-csi#121 from kvaps/namespace-check 8fdf0f78 Merge pull request kubernetes-csi#128 from fengzixu/master 1c94220d fix: fix a bug of csi-sanity a4c41e6a Merge pull request kubernetes-csi#127 from pohly/fix-boilerplate ece0f500 check namespace for snapshot-controller dbd89672 verify-boilerplate.sh: fix path to script 9289fd16 Merge pull request kubernetes-csi#125 from sachinkumarsingh092/optional-spelling-boilerplate-checks ad29307f Make the spelling and boilerplate checks optional 5f06d024 Merge pull request kubernetes-csi#124 from sachinkumarsingh092/fix-spellcheck-boilerplate-tests 48186eba Fix spelling and boilerplate errors 71690aff Merge pull request kubernetes-csi#122 from sachinkumarsingh092/include-spellcheck-boilerplate-tests 981be3fe Adding spelling and boilerplate checks. 2bb75253 Merge pull request kubernetes-csi#117 from fengzixu/master 3b6d17b1 Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout 9318c6cc cloud build: double the timeout, now 1 hour 4ab8b154 use the tag to replace commit of csi-test 5d74e455 change the csi-test import path to v4 7dcd0a99 upgrade csi-test to v4.0.2 86ff5802 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name c3a96625 allow export image name and registry name git-subtree-dir: release-tools git-subtree-split: 1d60e7792624a9938c0bd1b045211fbb89e513d6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
The one second timeout is based on the assumption that once the
connection is established, all further communication is going to be
fast.
That assumption doesn't hold in some special circumstances:
While this is a bit obscure, the flag is essential for these
cases. Adding the flag also makes the node-driver-registrar consistent
with other sidecars.
Special notes for your reviewer:
I have a prototype working with the mock driver embedded inside the e2e.test binary (the "proxying operation" case). I'll share more details after completing that work. In the meantime it would be good to get this PR included in the next release for Kubernetes 1.20.
Does this PR introduce a user-facing change?: