Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHANGELOG for v2.6.2 #254

Merged
merged 1 commit into from
Dec 1, 2022
Merged

CHANGELOG for v2.6.2 #254

merged 1 commit into from
Dec 1, 2022

Conversation

mauriciopoppe
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
CHANGELOG for v2.6.2

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 1, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 1, 2022
@mauriciopoppe
Copy link
Member Author

/uncc @j-griffith
/cc @andyzhangx

@k8s-ci-robot k8s-ci-robot requested review from andyzhangx and removed request for j-griffith December 1, 2022 05:21
@mauriciopoppe mauriciopoppe mentioned this pull request Dec 1, 2022
Merged
andyzhangx
andyzhangx approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2022
@mauriciopoppe
Copy link
Member Author

/assign @msau42

msau42
msau42 reviewed Dec 1, 2022
View reviewed changes
CHANGELOG/CHANGELOG-2.6.2.md

- Revert of #214, node-driver-registrar will create the path specified by `--kubelet-registration-path` ([#247](https://github.com/kubernetes-csi/node-driver-registrar/pull/247), [@mauriciopoppe](https://github.com/mauriciopoppe))

## Dependencies
Copy link
Collaborator

@msau42 msau42 Dec 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any changes that updated dependencies in the branch. Do you know where this is coming from?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this, I run it release-notes --discover=mergebase-to-latest and it looks like it's doing it again master, I used start and end git sha instead to get the correct output:

release-notes --start-sha eb068e4d75cfdac3489ebe50ff01d1c0b5446de6 --end-sha 6aa2ec170787b0ee471bcca1100bfb9f744686a8 \
--org=kubernetes-csi --repo=node-driver-registrar \
--required-author="" --output out.md

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for patch releases, our docs have a different command to use:

GITHUB_TOKEN=<token> release-notes \
  --discover=patch-to-latest \
  --branch=release-1.1 \
  --org=kubernetes-csi \
  --repo=external-provisioner \
  --required-author="" \
  --markdown-links \
  --output out.md

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 1, 2022
@msau42
Copy link
Collaborator

msau42 commented Dec 1, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, mauriciopoppe, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit f03b5bb into kubernetes-csi:release-2.6 Dec 1, 2022
sdx-jkataja added a commit to sdx-jkataja/node-driver-registrar that referenced this pull request Jul 25, 2024
@sdx-jkataja
Squashed 'release-tools/' changes from adb3af9d..988496a1
dd9772c 
988496a1 Merge pull request kubernetes-csi#257 from jakobmoellerdev/csi-prow-sidecar-e2e-path
028f8c69 chore: bump to Go 1.22.5
69bd71e8 chore: add CSI_PROW_SIDECAR_E2E_PATH
f40f0ccd Merge pull request kubernetes-csi#256 from solumath/master
cfa92106 Instruction update
379a1bb9 Merge pull request kubernetes-csi#255 from humblec/sidecar-md
a5667bbb fix typo in sidecar release process
49676850 Merge pull request kubernetes-csi#254 from bells17/add-github-actions
d9bd160c Update skip list in codespell GitHub Action
f5aebfc9 Add GitHub Actions workflows

git-subtree-dir: release-tools
git-subtree-split: 988496a1fc3849ed793e03012fdd56813d13d46c
sdx-jkataja added a commit to sdx-jkataja/node-driver-registrar that referenced this pull request Aug 9, 2024
@sdx-jkataja
Squashed 'release-tools/' changes from adb3af9d..988496a1
718bde1 
988496a1 Merge pull request kubernetes-csi#257 from jakobmoellerdev/csi-prow-sidecar-e2e-path
028f8c69 chore: bump to Go 1.22.5
69bd71e8 chore: add CSI_PROW_SIDECAR_E2E_PATH
f40f0ccd Merge pull request kubernetes-csi#256 from solumath/master
cfa92106 Instruction update
379a1bb9 Merge pull request kubernetes-csi#255 from humblec/sidecar-md
a5667bbb fix typo in sidecar release process
49676850 Merge pull request kubernetes-csi#254 from bells17/add-github-actions
d9bd160c Update skip list in codespell GitHub Action
f5aebfc9 Add GitHub Actions workflows

git-subtree-dir: release-tools
git-subtree-split: 988496a1fc3849ed793e03012fdd56813d13d46c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@andyzhangx andyzhangx andyzhangx approved these changes

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@andyzhangx andyzhangx

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mauriciopoppe @msau42 @k8s-ci-robot @andyzhangx