Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

Remove PersistentVolumeLabel admission controller flag #888

Merged
merged 1 commit into from
Feb 13, 2018
Merged

Remove PersistentVolumeLabel admission controller flag #888

merged 1 commit into from
Feb 13, 2018

Conversation

dghubble
Copy link
Contributor

  • PersistentVolumeLabel admission controller is deprecated in 1.9

I noticed warnings in apiserver logs that this admission controller is deprecated. It is indeed mentioned in 1.9 release deprecation notes and details are found in #52618.

* PersistentVolumeLabel admission controller is deprecated in 1.9
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 12, 2018
Copy link
Contributor

@ericchiang ericchiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ericchiang
Copy link
Contributor

@rphillips seeing this in the logs

https://jenkins-kube-lifecycle.prod.coreos.systems/job/bootkube-pr-e2e/891/console

2018-02-12T23:02:11.523144089Z I0212 23:02:11.520918       1 main.go:47] Determining environment from downward API
2018-02-12T23:02:11.523213183Z I0212 23:02:11.522846       1 main.go:53] Trying to acquire the flock at "/var/run/lock/pod-checkpointer.lock"
2018-02-12T23:02:11.523219752Z I0212 23:02:11.522915       1 main.go:58] Starting checkpointer for node: ip-10-8-0-189.ec2.internal
2018-02-12T23:02:11.538080611Z I0212 23:02:11.537854       1 runtime_service.go:22] Connecting to runtime service unix:///var/run/dockershim.sock
2018-02-12T23:02:26.163015696Z W0212 23:02:26.153062       1 apiserver.go:20] Unable to contact APIServer, skipping garbage collection: pods is forbidden: User "system:serviceaccount:kube-system:pod-checkpointer" cannot list pods in the namespace "kube-system"
2018-02-12T23:02:31.765769626Z I0212 23:02:31.680080       1 process.go:197] Checkpoint kube-system/kube-apiserver-c2cgb (active) transitioning from state active -> state active (grace period)
2018-02-12T23:03:35.333178894Z I0212 23:03:35.333010       1 state.go:306] Grace period exceeded for state active (grace period)
2018-02-12T23:03:35.333692818Z I0212 23:03:35.333116       1 state.go:207] Grace period exceeded for state inactive (grace period)
2018-02-12T23:03:35.333706395Z I0212 23:03:35.333266       1 process.go:197] Checkpoint kube-system/kube-apiserver-c2cgb (active (grace period)) transitioning from state active (grace period) -> state remove
2018-02-12T23:03:35.333712559Z I0212 23:03:35.333376       1 process.go:268] Removing checkpoint of: kube-system/kube-apiserver-c2cgb

@rphillips
Copy link
Contributor

nice find

@rphillips
Copy link
Contributor

coreosbot run e2e

@rphillips rphillips merged commit 7aa7567 into kubernetes-retired:master Feb 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants