-
Notifications
You must be signed in to change notification settings - Fork 67
Correct manifest path since the file name has been changed in previously ccommit #142
Correct manifest path since the file name has been changed in previously ccommit #142
Conversation
Hi @vincent-pli. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fei-Guo, vincent-pli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Whoops, this is probably going to need more updates to work correctly, because the images aren't published anywhere this manifest will fail to be used for any cluster that you don't run Given this isn't ready how should we handle the updates to this? Should we revert since you should be able to use VC w/o CAPN right now via the old readme, and then once we get #129 and #130 ? |
@Fei-Guo @vincent-pli ^^^^ |
@christopherhein Yes. I think you overwrote the old all_in_one with all_in_one_capi? can you add the old all_in_one back and revert the README to the old all_in_one? |
Oh shoot, wow. sorry I missed that, yea we can add that manifest back. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #