Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Correct manifest path since the file name has been changed in previously ccommit #142

Merged

Conversation

vincent-pli
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 19, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @vincent-pli. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 19, 2021
@Fei-Guo
Copy link

Fei-Guo commented Jun 19, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fei-Guo, vincent-pli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7922cae into kubernetes-retired:main Jun 19, 2021
@christopherhein
Copy link
Contributor

Whoops, this is probably going to need more updates to work correctly, because the images aren't published anywhere this manifest will fail to be used for any cluster that you don't run make build-images and thus don't push those images into the kind or minikube cluster, it also requires CAPN which will require the user to do and follow the docs/README.md.

Given this isn't ready how should we handle the updates to this? Should we revert since you should be able to use VC w/o CAPN right now via the old readme, and then once we get #129 and #130 ?

@christopherhein
Copy link
Contributor

@Fei-Guo @vincent-pli ^^^^

@Fei-Guo
Copy link

Fei-Guo commented Jun 21, 2021

@christopherhein Yes. I think you overwrote the old all_in_one with all_in_one_capi? can you add the old all_in_one back and revert the README to the old all_in_one?

@christopherhein
Copy link
Contributor

Oh shoot, wow. sorry I missed that, yea we can add that manifest back.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants