This repository was archived by the owner on Dec 6, 2024. It is now read-only.
monorepo: move api directories into ./client #78
Merged
+2
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
BlaineEXE
force-pushed
the
start-api-reorg
branch
from
c0b6c86 to
6d15159
Compare
Begin the process of moving API directories into ./client. We believe https://github.com/kubernetes-csi/external-snapshotter is using the latest best practices for CSI, Kubernetes, and Golang projects and are following its structure as a guide. - mv ./apis -> ./client/apis - mv ./crds -> ./client/config/crd (note the change from crds to crd) - mv ./hack -> ./client/hack - disable CI tests in Makefile while things are expected to be failing No further changes are made in order to keep the changes for this commit concise. Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
BlaineEXE
force-pushed
the
start-api-reorg
branch
from
6d15159 to
ab36b8a
Compare
Contributor
|
Can you add a note about the TODO in the PR description? |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BlaineEXE, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begin the process of moving API directories into ./client. We believe https://github.com/kubernetes-csi/external-snapshotter is using the latest best practices for CSI, Kubernetes, and Golang projects and are following its structure as a guide.
No further changes are made in order to keep the changes for this commit concise.
This means that the hack scripts are broken, and the go mod may not be working either. This is intended at this time because we want to track hack script and go mod changes explicitly, which will come next.