This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
WIP: [nginx-ingress-controller] Add support for rewrite #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| const ( | ||
| rewriteTo = "ingress-nginx.kubernetes.io/rewrite-to" | ||
| addBaseURL = "ingress-nginx.kubernetes.io/add-base-url" |
There was a problem hiding this comment.
please add an example in the readme with how these interact with the controller and ingresses in the cluster
There was a problem hiding this comment.
yes, this is what's missing now
|
Looks good, mostly just stylistic comments. Rewrites are so common that I think we should document this with ample examples (with without base, with regex etc). |
aledbf
force-pushed
the
ingress-redirect
branch
2 times, most recently
from
c838cbd
to
4924b57
Compare
| @@ -0,0 +1,67 @@ | |||
|
|
|||
| Create an Ingress rule with a rewrite annotation: | |||
There was a problem hiding this comment.
can you also add an examble with base path?
There was a problem hiding this comment.
yes, I'm searching for a sample app :)
|
You have a merge conflict, LGTM but for the doc nit |
|
@bprashanth can we left the missing example for #1104? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #860