This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Fix nginx ingress controller bug around config map merging #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* a config map bool value of false cannot overwritte a true value from defaults * implement merging in ReadConfig * remove helper function merge * adds tests to ensure config is read properly
|
Code LGTM |
|
@simonswine thanks, merging |
This was referenced May 2, 2016
aledbf
pushed a commit
to aledbf/contrib
that referenced
this pull request
Nov 10, 2016
…te-true-with-configmamp Fix nginx ingress controller bug around config map merging
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi I just discovered a bug around the nginx config merge (defaults are merged with configmap)
defaults