-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
Refactor to app & pkg directories
Add some unit tests & improve logging
Use mountdevice callout based on plugin capability
Refactor drivers to CSI 0.2.0 spec
refactor csi-common and hostpath plugin to use new api objects
This patch updates the README for plugins for CSI 0.2.0. It includes the following changes: - Updates the CSC tool location - Removes "get supported versions" because that was removed from CSI.
Update CSI Plugins README
Update image links for NFS
Update to CSI 0.3
Update drivers to pick up CSI 1.0.0
The repo was created with an HTML version of the build.make file from https://github.com/pohly/csi-build-rules/. Here's the raw file.
It's worth calling out explicitly that only the master branch is maintained.
/assign @msau42 |
/assign @chakri-nelluri |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@pohly could you help verify the release-tools import was done correctly? |
We've had that before and it was agreed to by-pass the CLA check (kubernetes-csi/csi-driver-host-path#1) - I personally prefer that over loosing history.
Yes, all looks good and |
OK, I'll update it. |
I think it's better to keep the original commits too. |
/lgtm Force merging to skip cla check |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cofyc, msau42 If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cofyc can you also help setup test-infra for this repo? Maybe just enable unit test jobs for now until we're ready for image building. https://github.com/kubernetes/test-infra/tree/master/config/jobs/kubernetes-csi |
What type of PR is this?
What this PR does / why we need it:
git subtree add --prefix=release-tools https://github.com/kubernetes-csi/csi-release-tools.git master
)git clone git@github.com:kubernetes-csi/drivers.git
git filter-branch --index-filter 'git rm --cached -qr --ignore-unmatch -- . && git reset -q $GIT_COMMIT -- app/flexadapter pkg/flexadapter' --prune-empty -- --all
copy flexadapter files from driversWhich issue(s) this PR fixes:
Fixes #1
Special notes for your reviewer:
Does this PR introduce a user-facing change?: