Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Use etcd 3.4 client #363

Merged

Conversation

justinsb
Copy link
Contributor

@justinsb justinsb commented Feb 4, 2023

3.5 seems to have regressed on kubernetes/kubernetes#72102

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 4, 2023
@justinsb justinsb force-pushed the etcd_client_34_works branch from bd3682d to 14051c3 Compare February 4, 2023 15:14
@justinsb justinsb changed the title etcd client 34 works Use etcd 3.4 client Feb 4, 2023
@justinsb
Copy link
Contributor Author

justinsb commented Feb 4, 2023

/test cluster-create-phases-test

@k8s-ci-robot
Copy link
Contributor

@justinsb: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-etcdadm-test-init
  • /test pull-etcdadm-verify

Use /test all to run all jobs.

In response to this:

/test cluster-create-phases-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justinsb justinsb force-pushed the etcd_client_34_works branch from 14051c3 to b2854ea Compare February 4, 2023 15:54
3.5 seems to have regressed on kubernetes/kubernetes#72102
With etcd client v3.4, this test should pass.

This reverts commit 2201714.
@justinsb justinsb force-pushed the etcd_client_34_works branch from b2854ea to faf4eaa Compare February 4, 2023 16:04
@hakman
Copy link
Contributor

hakman commented Feb 4, 2023

/lgtm
/hold in case there's something missing

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2023
@justinsb
Copy link
Contributor Author

justinsb commented Feb 4, 2023

This is looking good I think ... 3.4 is passing, 3.5 is failing only on the test which shows the regression. Going to merge this one.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit d3c7c31 into kubernetes-retired:master Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants