Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

Use tide for PR merging #343

Closed
spiffxp opened this issue Sep 11, 2018 · 1 comment
Closed

Use tide for PR merging #343

spiffxp opened this issue Sep 11, 2018 · 1 comment

Comments

@spiffxp
Copy link
Contributor

spiffxp commented Sep 11, 2018

This is a core repository. As such, it needs to use the same merge automation as the rest of the project

I have a PR open that will address this at an org-wide level: kubernetes/test-infra#9342. It will:

  • enable the approve plugin, to allow use of the /approve plugin
  • enable the blunderbuss plugin, to assign reviews based on OWNERS files
  • add all repos in the kubernetes org to tide's query

Can one of the repo maintainers here drop an LGTM (or objections) on the linked PR? Alternatively, if I hear no objections by Monday 10am PT of next week, I will merge the PR.

@resouer
Copy link
Contributor

resouer commented Sep 12, 2018

Thanks a lot @spiffxp for helping enable this, it's awesome!

Just LGTM on the linked PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants