Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup org-wide automation for kubernetes #9342

Merged
merged 2 commits into from
Sep 17, 2018
Merged

Setup org-wide automation for kubernetes #9342

merged 2 commits into from
Sep 17, 2018

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Sep 11, 2018 •
edited
Loading

This makes our config for kubernetes match our config for kubernetes-sigs,
by configuring things at the org level rather than a per-repo level.

This is consistent with our rules for core repositories

As a consequence, the following repos will have approve and blunderbuss enabled, and will be added to tide (ref: #6227):

The following repos will have blunderbuss enabled:

  • kubernetes/autoscaler
  • kubernetes/client-go
  • kubernetes/cluster-registry
  • kubernetes/dashboard
  • kubernetes/dns
  • kubernetes/examples
  • kubernetes/features
  • kubernetes/federation
  • kubernetes/frakti
  • kubernetes/gengo
  • kubernetes/git-sync
  • kubernetes/ingress-nginx
  • kubernetes/k8s.io
  • kubernetes/kompose
  • kubernetes/kops
  • kubernetes/kubeadm
  • kubernetes/kubectl
  • kubernetes/kubernetes-anywhere
  • kubernetes/kubernetes-template-project
  • kubernetes/minikube
  • kubernetes/release
  • kubernetes/steering

/hold
for comment, and to give us more time to ensure kubernetes/kubernetes is functioning well

/assign @cjwagner
I think you've expressed performance/token concerns about enabling approve and blunderbuss at the org level in the past

/kind cleanup
/area prow
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2018
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/prow Issues or PRs related to prow priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 11, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2018
@spiffxp
Add approve, blunderbuss plugins to kubernetes org
fd2cc2a 
Some repos will get new plugins as a result. Excluding
staging repos, there are 6 repos that get approve, and
22 repos that get blunderbuss

+blunderbuss
  client-go
  cluster-registry
  dashboard
  dns
  examples
  features
  ingress-nginx
  federation
  gengo
  kops
  kubeadm
  kubectl
  kubernetes-template-project
  minikube
  release
  steering

+approve +blunderbuss
  autoscaler
  frakti
  git-sync
  k8s.io
  kompose
  kubernetes-anywhere
@spiffxp
Add all kubernetes/* repos to tide
c0b76ad 
This will add the following repos that weren't previously in tide:

autoscaler
frakti
git-sync
k8s.io
kompose
kubrnetes-anywhere
@spiffxp spiffxp force-pushed the kubernetes-org-level-automation branch from b049630 to c0b76ad Compare September 11, 2018 19:24
@cblecker
Copy link
Member

This LGTM. Biggest concern is merge automation that could catch people off guard.

@spiffxp
Copy link
Member Author

spiffxp commented Sep 11, 2018

Yeah I'm planning on tagging repos and owners of those repos once I get a feel for a good lazy consensus deadline.

@fejta
Copy link
Contributor

fejta commented Sep 11, 2018

LvGTM

This was referenced Sep 11, 2018
Closed
Closed
Closed
Closed
Closed
Closed
@neolit123
Copy link
Member

neolit123 commented Sep 11, 2018 •
edited
Loading

LGTM for adding tide to k/kubernetes-anywhere
https://github.com/orgs/kubernetes/teams/kubernetes-anywhere-maintainers/members
i was recently added on that list, but i'm sure that nobody will have objections.

@spiffxp
Copy link
Member Author

spiffxp commented Sep 11, 2018

I don't want to chase down 22 repo owners for blunderbuss, but that's a somewhat wide blast radius, so I sent out a kubernetes-dev@ thread with lazy consensus deadline of Monday 2018-09-17 10am PT

@resouer
Copy link
Contributor

resouer commented Sep 12, 2018

LGTM for kubernetes/frakti, thanks a lot!

@hangyan
Copy link

hangyan commented Sep 12, 2018

LGTM for kubernetes/kompose, thanks a lot!

@thockin
Copy link
Member

thockin commented Sep 12, 2018

LGTM for k8s.io and git-sync repos.

@dims
Copy link
Member

dims commented Sep 17, 2018

/lgtm

/hold

(please cancel when appropriate)

@spiffxp
Copy link
Member Author

spiffxp commented Sep 17, 2018

/hold cancel
lazy consensus deadline has passed
only repo that hasn't given explicit LGTM is kubernetes/autoscaler: one of their maintainers was fine with it, one was concerned this would add k/k's merge requirements (it won't)

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 16d01f4 into kubernetes:master Sep 17, 2018
@spiffxp spiffxp deleted the kubernetes-org-level-automation branch September 17, 2018 17:11
@ixdy
Copy link
Member

ixdy commented Sep 17, 2018

why hasn't prow picked this up?

@spiffxp
Copy link
Member Author

spiffxp commented Sep 17, 2018

We're lucky it didn't. #9447

We think it was a dropped webhook

@spiffxp spiffxp mentioned this pull request Sep 17, 2018
Merged
@spiffxp
Copy link
Member Author

spiffxp commented Sep 17, 2018

That revert was just for config.yaml, so this means plugins.yaml is still out of sync with the repo

This was referenced Sep 17, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker Awaiting requested review from cblecker

@spxtr spxtr Awaiting requested review from spxtr

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@dims dims

@cjwagner cjwagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.