-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add RBAC rules to the heapster manifests and combine logical API objects into the same file #1612
Conversation
name: heapster | ||
namespace: kube-system | ||
--- | ||
kind: ClusterRoleBinding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the service account and deployment are logically paired. the RBAC objects are not, since they would not apply if RBAC authz was not in use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any harm done if it's applied/created when RBAC is not in use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if RBAC is not in use, default roles/rolebindings are not created
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, gotcha. Updated
…cts into the same file
/lgtm |
can not find where defined the clusterRole
can't found clusterRole definition.
|
A lot of these manifests are/were obsolete, I'd be very happy to remove/cleanup things here.
RBAC is turned on by default in v1.6 and heapster is broken without credentials granted to it
I didn't touch standalone-test nor standalone-with-apiserver, are those relevant anymore?
fixes: kubernetes/kubeadm#248 cc @sebgoa
PTAL @DirectXMan12 @piosz @mwielgus and please merge ASAP