This repository has been archived by the owner on Dec 1, 2018. It is now read-only.
fix docs&&misc about delete pod_namespace #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
DirectXMan12
approved these changes
May 25, 2017
|
Why have you deleted this field from the es mapping?
On Thu, 25 May 2017 at 18:24 Solly Ross ***@***.***> wrote:
@DirectXMan12 <https://github.com/directxman12> requested your review on:
kubernetes-retired/heapster#1661
<#1661> fix docs&&misc about
delete pod_namespace.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1661 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAGCponRmQrQ5xU8LtrsNQV1yPBr_sbAks5r9Z0PgaJpZM4Nl72a>
.
--
<http://www.rimoto.net/>
www.rimoto.com <http://www.rimoto.net/>
*Almog Baku*
*CTO & Cofounder *
Mobile: +972.50.2288.744
Social: * <http://www.facebook.com/AlmogBaku>
<http://www.linkedin.com/in/almogbaku>*
|
|
@AlmogBaku |
|
Friendly ping @piosz @DirectXMan12 |
|
@piosz @DirectXMan12 PTAL. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is followed by #1659.
I have forgot to grep
pod_namespaceusage instead ofLabelPodNamespace. This PR will clean the usage aboutpod_namespace./ping @kubernetes/heapster-maintainers @piosz @DirectXMan12
This also change code with ES, so @AlmogBaku PTAL.