Skip to content
This repository has been archived by the owner on Dec 1, 2018. It is now read-only.

Set the name of k8s cluster in Stackdriver sink. #1703

Merged
merged 1 commit into from
Jun 28, 2017
Merged

Set the name of k8s cluster in Stackdriver sink. #1703

merged 1 commit into from
Jun 28, 2017

Conversation

kawych
Copy link
Contributor

@kawych kawych commented Jun 28, 2017

Add a parameter to Heapster that allows to set resource label 'cluster_name' for metrics exported to Stackdriver.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 28, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@piosz
Copy link
Contributor

piosz commented Jun 28, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2017
@kawych
Copy link
Contributor Author

kawych commented Jun 28, 2017

I've signed the cla.

@piosz piosz closed this Jun 28, 2017
@piosz piosz reopened this Jun 28, 2017
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 28, 2017
@piosz
Copy link
Contributor

piosz commented Jun 28, 2017

closed/reopened to re-trigger cla verification

@piosz piosz merged commit 150589b into kubernetes-retired:master Jun 28, 2017
@k8s-ci-robot
Copy link
Contributor

@kawych: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-heapster-e2e cbc2b02 link /test pull-heapster-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants