Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Commit

Permalink
CoreDNS prometheus metric annotations exposed at pod level
Browse files Browse the repository at this point in the history
These annotations would previously never be rendered because they
were added under the kube-dns section (rather than CoreDNS's).
Additionally, the annotations are now added to the Pods themselves
rather than the Deployment.

Fixes #1768
  • Loading branch information
kfr2 committed Oct 28, 2019
1 parent 8ef6fa4 commit 93586ac
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions builtin/files/userdata/cloud-config-controller
Original file line number Diff line number Diff line change
Expand Up @@ -4106,6 +4106,8 @@ write_files:
labels:
k8s-app: kube-dns
annotations:
prometheus.io/port: "9153"
prometheus.io/scrape: "true"
seccomp.security.alpha.kubernetes.io/pod: 'docker/default'
spec:
priorityClassName: system-node-critical
Expand Down Expand Up @@ -4200,11 +4202,6 @@ write_files:
labels:
k8s-app: kube-dns
kubernetes.io/cluster-service: "true"
{{- if eq .KubeDns.Provider "coredns" }}
annotations:
prometheus.io/port: "9153"
prometheus.io/scrape: "true"
{{- end }}
spec:
# replicas: not specified here:
# 1. In order to make Addon Manager do not reconcile this replicas parameter.
Expand Down

0 comments on commit 93586ac

Please sign in to comment.