Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Add a Pod Disruption Budget on kube-dns #1467

Merged
merged 3 commits into from
Oct 26, 2018

Conversation

davidmccormick
Copy link
Contributor

Improve the handling of kube-dns during node drains / cluster rolls by defining a pod disruption budget that allows 1 instance to be down.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: danielfm

If they are not already assigned, you can assign the PR to them by writing /assign @danielfm in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-io
Copy link

Codecov Report

Merging #1467 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1467   +/-   ##
=======================================
  Coverage   37.88%   37.88%           
=======================================
  Files          75       75           
  Lines        4593     4593           
=======================================
  Hits         1740     1740           
  Misses       2611     2611           
  Partials      242      242

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6245b47...9c3ba92. Read the comment docs.

Copy link
Contributor

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM. Thanks for your contribution as always ☺️

@mumoshu mumoshu merged commit aca24cf into kubernetes-retired:master Oct 26, 2018
@mumoshu mumoshu added this to the v0.12.0 milestone Oct 26, 2018
@davidmccormick davidmccormick deleted the pdb-4-kubedns branch January 2, 2019 11:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants