Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Master: Add DnsMasq (node local resolver) command-line arguments/options #1527

Conversation

davidmccormick
Copy link
Contributor

After some issues with DNS in our AWS environments we noticed that we were caching negative DNS responses for longer than we would have expected. This PR is quite general in that it allows us to add our own options for the node local dnsmasq daemonset (which allows us to fine tune our settings, such as the negative ttl setting).

kubeDns:
  nodeLocalResolver: true
  nodeLocalResolverOptions:
  - --neg-ttl=10

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: danielfm

If they are not already assigned, you can assign the PR to them by writing /assign @danielfm in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidmccormick davidmccormick force-pushed the nodelocal-dnsmasq-options branch from 8b3ec09 to 70123fd Compare January 11, 2019 09:52
@davidmccormick davidmccormick changed the title Allow nodelocal dnsmasq options Master: Add DnsMasq (node local resolver) command-line arguments/options Jan 11, 2019
@codecov-io
Copy link

codecov-io commented Jan 11, 2019

Codecov Report

Merging #1527 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1527   +/-   ##
=======================================
  Coverage   25.46%   25.46%           
=======================================
  Files          97       97           
  Lines        5003     5003           
=======================================
  Hits         1274     1274           
  Misses       3582     3582           
  Partials      147      147
Impacted Files Coverage Δ
pkg/api/types.go 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9183dd...70123fd. Read the comment docs.

@davidmccormick davidmccormick merged commit c50c2a0 into kubernetes-retired:master Jan 11, 2019
@davidmccormick davidmccormick added this to the v0.13.0 milestone Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants