Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Master: Bump default Kubernetes Dashboard version and add AllowSkipLogin option #1536

Conversation

kylehodgetts
Copy link
Contributor

We ran into some issues with the dashboard being slow at version v1.8.3 and these seem to have gone away in v1.10.1

However in v1.10.1 the skip login option is now disabled by default and requires the use of --enable-skip-login flag to bring it back. This has been added in as an option AllowSkip in the KubernetesDashboard struct and takes a default value of false

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 15, 2019
@kylehodgetts kylehodgetts changed the title Bump default Kubernetes Dashboard version and add AllowSkip option Master: Bump default Kubernetes Dashboard version and add AllowSkip option Jan 15, 2019
@codecov-io
Copy link

codecov-io commented Jan 15, 2019

Codecov Report

Merging #1536 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1536      +/-   ##
==========================================
- Coverage   25.45%   25.45%   -0.01%     
==========================================
  Files          97       97              
  Lines        5004     5005       +1     
==========================================
  Hits         1274     1274              
- Misses       3583     3584       +1     
  Partials      147      147
Impacted Files Coverage Δ
pkg/api/cluster.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e0e8be...f70b55f. Read the comment docs.

@kylehodgetts kylehodgetts changed the title Master: Bump default Kubernetes Dashboard version and add AllowSkip option Master: Bump default Kubernetes Dashboard version and add AllowSkipLogin option Jan 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mumoshu

If they are not already assigned, you can assign the PR to them by writing /assign @mumoshu in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidmccormick davidmccormick merged commit 9a9fecb into kubernetes-retired:master Jan 17, 2019
@davidmccormick
Copy link
Contributor

Thanks for you contribution!

@davidmccormick davidmccormick added this to the v0.13.0 milestone Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants