Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Make dashboard replicas configurable #1539

Conversation

kylehodgetts
Copy link
Contributor

@kylehodgetts kylehodgetts commented Jan 16, 2019

Currently, only 1 dashboard instance is configured to run when the cluster is spun up.
This requires a manual edit of the kubernetes-dashboard deployment to change this.

If a cluster goes through an update, then the figure is then reset back to one.

This change allows for the value to be configured.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kylehodgetts
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mumoshu

If they are not already assigned, you can assign the PR to them by writing /assign @mumoshu in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 16, 2019
@codecov-io
Copy link

Codecov Report

Merging #1539 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1539      +/-   ##
==========================================
- Coverage   25.46%   25.45%   -0.01%     
==========================================
  Files          97       97              
  Lines        5003     5004       +1     
==========================================
  Hits         1274     1274              
- Misses       3582     3583       +1     
  Partials      147      147
Impacted Files Coverage Δ
pkg/api/cluster.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c50c2a0...f292965. Read the comment docs.

@davidmccormick davidmccormick merged commit 6e0e8be into kubernetes-retired:master Jan 17, 2019
@davidmccormick davidmccormick added this to the v0.13.0 milestone Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants