-
Notifications
You must be signed in to change notification settings - Fork 294
Allowing adding arbitrary flags to kubernetes core components through plugins #1564
Allowing adding arbitrary flags to kubernetes core components through plugins #1564
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #1564 +/- ##
==========================================
+ Coverage 25.8% 25.85% +0.05%
==========================================
Files 98 98
Lines 5057 5062 +5
==========================================
+ Hits 1305 1309 +4
- Misses 3605 3606 +1
Partials 147 147
Continue to review full report at Codecov.
|
64e9024
to
75d9034
Compare
/assign @davidmccormick |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments on naming. This seems like a great idea though!
d2b8fb1
to
9c326ec
Compare
9c326ec
to
f0c7bba
Compare
@mumoshu I have refactored it and test it again by spinning a cluster. |
/lgtm |
Thanks @omar-nahhas for your continued support! 🙏 |
I'm not sure if I understand how to include a plugin that will allow me to configure the kube-controller-manager flags. My goal is to add this flag Any guidance or examples would be highly appreciated. |
This PR Is to allow adding specific configuration flags to the kube-proxy, kubelet and kube-scheduler through plugins, it is an extension of the currently existing functionality to add fags to the kubeapi and kube-controller-manager.
In the plugin.yaml you can add flags like follows:
Then they will be injected on the configuration of the specific components: