-
Notifications
You must be signed in to change notification settings - Fork 294
Allow plugins to add CFN tags and outputs #1575
Allow plugins to add CFN tags and outputs #1575
Conversation
Bring our master in line with upstream
/assign @redbaron |
/assign @davidmccormick |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #1575 +/- ##
==========================================
+ Coverage 25.8% 25.81% +<.01%
==========================================
Files 98 98
Lines 5057 5063 +6
==========================================
+ Hits 1305 1307 +2
- Misses 3605 3609 +4
Partials 147 147
Continue to review full report at Codecov.
|
/lgtm |
Thanks @Luke-Humphreys for this useful expansion of our plugin functionality! 🙏 |
What
Adding the ability for plugins to inject cloud formation tags into control plane and node pool stacks.
Adding the ability for plugins to inject output cloud formation into control plane, node pool, etcd and network stacks.
Why
In the process of developing a plugin for the cluster-autoscaler I noticed that you can only inject resources into cloud formation stacks from plugins, this meant I couldn't add the necessary ASG tags for the cluster-autoscaler. The functionality was already there, I just extended it a little bit.