Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Etcd Subnets not honoured on stack render. #1583

Merged
merged 2 commits into from
May 2, 2019
Merged

Etcd Subnets not honoured on stack render. #1583

merged 2 commits into from
May 2, 2019

Conversation

dominicgunn
Copy link
Contributor

Changes

  • etcd subnets are not respected when generating a new etcd stack, this ensures we at least look at the declared etcd subnets and try to match them up.

Resolves #1579

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mumoshu

If they are not already assigned, you can assign the PR to them by writing /assign @mumoshu in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 1, 2019
@k8s-ci-robot k8s-ci-robot requested review from danielfm and redbaron May 1, 2019 09:47
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 1, 2019
@dominicgunn dominicgunn changed the title Ensure we use etcdSubnets if they have been configured Etcd Subnets not honoured on stack render. May 1, 2019
@davidmccormick
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 1, 2019
@codecov-io
Copy link

codecov-io commented May 1, 2019

Codecov Report

Merging #1583 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1583      +/-   ##
==========================================
- Coverage   25.86%   25.83%   -0.04%     
==========================================
  Files          98       98              
  Lines        5068     5075       +7     
==========================================
  Hits         1311     1311              
- Misses       3610     3617       +7     
  Partials      147      147
Impacted Files Coverage Δ
pkg/model/stack_new.go 32.02% <0%> (-1.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de82a15...7edc8ae. Read the comment docs.

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 1, 2019
@davidmccormick
Copy link
Contributor

Is this change now ready?

@davidmccormick davidmccormick added this to the v0.13.0 milestone May 2, 2019
@paalkr
Copy link
Contributor

paalkr commented May 2, 2019

I can confirm that this patch resolves #1579
Thanks!

@davidmccormick davidmccormick merged commit 67869df into kubernetes-retired:master May 2, 2019
@davidmccormick
Copy link
Contributor

Thanks for your contribution! 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

etcd stack does not honor etcd.subnets: config for unmanaged subnets
5 participants