Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

V0.13.x autoscaler work #1618

Merged
merged 2 commits into from
Jun 10, 2019
Merged

V0.13.x autoscaler work #1618

merged 2 commits into from
Jun 10, 2019

Conversation

davidmccormick
Copy link
Contributor

No description provided.

@davidmccormick
Migrate to plugin based autoscaler.
b378436 
Remove all legacy autoscaler core code and references.

Don't try to range over options if it is not there

Fix plugins configs missing from nodepool configs.  Remove attempt to add duplicate kubernetes.io/cluster/name tag.

Update plugin values merging behavior so that NodePool stacks and userdata can inherit values from the main PluginConfig section and override them instead of having to define all repeatedly in the nodepool configs.
@davidmccormick
Use v0.13.x node lables
35d6a3c
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 5, 2019
@k8s-ci-robot k8s-ci-robot requested review from cknowles and mumoshu June 5, 2019 14:33
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: redbaron

If they are not already assigned, you can assign the PR to them by writing /assign @redbaron in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 5, 2019
@codecov-io
Copy link

Codecov Report

Merging #1618 into v0.13.x will increase coverage by 0.07%.
The diff coverage is 13.79%.

Impacted file tree graph

@@             Coverage Diff             @@
##           v0.13.x    #1618      +/-   ##
===========================================
+ Coverage    25.46%   25.54%   +0.07%     
===========================================
  Files           97       98       +1     
  Lines         5042     5038       -4     
===========================================
+ Hits          1284     1287       +3     
+ Misses        3614     3608       -6     
+ Partials       144      143       -1
Impacted Files Coverage Δ
pkg/api/worker_node_pool.go 12.38% <ø> (+0.52%) ⬆️
pkg/api/types.go 0% <ø> (ø) ⬆️
pkg/api/controller.go 0% <ø> (ø) ⬆️
pkg/api/plugin_config.go 0% <0%> (ø)
pkg/api/cluster.go 0% <0%> (ø) ⬆️
pkg/model/stack_new.go 33.86% <0%> (ø) ⬆️
pkg/model/node_pool_config.go 24.67% <0%> (+0.92%) ⬆️
credential/store.go 42.1% <50%> (ø) ⬆️
pkg/model/node_pool_compile.go 59.21% <60%> (+4.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd86e8f...35d6a3c. Read the comment docs.

@davidmccormick davidmccormick added this to the v0.13.0-rc.3 milestone Jun 10, 2019
@davidmccormick davidmccormick merged commit 62f21d6 into kubernetes-retired:v0.13.x Jun 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cknowles cknowles Awaiting requested review from cknowles

@mumoshu mumoshu Awaiting requested review from mumoshu

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidmccormick @k8s-ci-robot @codecov-io