Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

[v0.14.x] Configurable CoreDNS TTL #1626

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Conversation

dominicgunn
Copy link
Contributor

Changes

  • Allows a configurable TTL for CoreDNS.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign mumoshu
You can assign the PR to them by writing /assign @mumoshu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-io
Copy link

Codecov Report

Merging #1626 into v0.14.x will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           v0.14.x    #1626      +/-   ##
===========================================
- Coverage    25.54%   25.54%   -0.01%     
===========================================
  Files           98       98              
  Lines         5038     5039       +1     
===========================================
  Hits          1287     1287              
- Misses        3608     3609       +1     
  Partials       143      143
Impacted Files Coverage Δ
pkg/api/types.go 0% <ø> (ø) ⬆️
pkg/api/cluster.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63ffc1f...a32671a. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #1626 into v0.14.x will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           v0.14.x    #1626      +/-   ##
===========================================
- Coverage    25.54%   25.54%   -0.01%     
===========================================
  Files           98       98              
  Lines         5038     5039       +1     
===========================================
  Hits          1287     1287              
- Misses        3608     3609       +1     
  Partials       143      143
Impacted Files Coverage Δ
pkg/api/types.go 0% <ø> (ø) ⬆️
pkg/api/cluster.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63ffc1f...a32671a. Read the comment docs.

@davidmccormick
Copy link
Contributor

Would you be so kind as to also PR this to master? Then I will merge both 🙏

@davidmccormick davidmccormick added this to the v0.14.0-rc.3 milestone Jun 17, 2019
@dominicgunn
Copy link
Contributor Author

Here you go @davidmccormick, #1627.

@davidmccormick davidmccormick merged commit cea7b06 into v0.14.x Jun 18, 2019
@mumoshu mumoshu deleted the v0.14.x-core-dns-ttl branch June 20, 2019 15:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants